All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: LEROY Christophe <christophe.leroy@c-s.fr>
Cc: linuxppc-dev@ozlabs.org, chunkeey@gmail.com
Subject: Re: [PATCH 1/2] powerpc/4xx/ocm: Fix phys_addr_t printf warnings
Date: Wed, 02 Jan 2019 22:12:52 +1100	[thread overview]
Message-ID: <87lg43xqh7.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20190101175219.Horde.M9y96Jn9ywiZ5BbROIsFAg1@messagerie.si.c-s.fr>

LEROY Christophe <christophe.leroy@c-s.fr> writes:

> Michael Ellerman <mpe@ellerman.id.au> a écrit :
>
>> Currently the code produces several warnings, eg:
>>
>>   arch/powerpc/platforms/4xx/ocm.c:240:38: error: format '%llx'
>>   expects argument of type 'long long unsigned int', but argument 3
>>   has type 'phys_addr_t {aka unsigned int}'
>>      seq_printf(m, "PhysAddr     : 0x%llx\n", ocm->phys);
>>                                    ~~~^     ~~~~~~~~~
>>
>> Fix it by using the special %pa[p] format for printing phys_addr_t.
>> Note we need to pass the value by reference for the special specifier
>> to work.
>
> When I fixed the same problem in prom.c, you suggested to simply cast  
> it to unsigned long long. Is this a better solution ?

Did I?

Oh you mean here:
  https://patchwork.ozlabs.org/patch/1012875/


Yeah I was just commenting on the ifdef, I didn't actually realise it
was a phys_addr_t that was the cause of the problem.

So yeah I guess it is preferable to use %pa[p] in prom.c as well.

cheers

  reply	other threads:[~2019-01-02 11:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-01  3:56 [PATCH 1/2] powerpc/4xx/ocm: Fix phys_addr_t printf warnings Michael Ellerman
2019-01-01  3:56 ` [PATCH 2/2] powerpc/configs: Add PPC4xx_OCM to ppc40x_defconfig Michael Ellerman
2019-01-01 16:52 ` [PATCH 1/2] powerpc/4xx/ocm: Fix phys_addr_t printf warnings LEROY Christophe
2019-01-02 11:12   ` Michael Ellerman [this message]
2019-01-02 11:31 ` [1/2] " Michael Ellerman
2019-01-04 20:46   ` Christian Lamparter
2019-01-08  9:54     ` Michael Ellerman
2019-01-08 17:21       ` Christian Lamparter
2019-01-11 13:10         ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lg43xqh7.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=christophe.leroy@c-s.fr \
    --cc=chunkeey@gmail.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.