From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 6291F1BF3D9 for ; Sat, 24 Nov 2018 00:21:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 5E7A5887EB for ; Sat, 24 Nov 2018 00:21:20 +0000 (UTC) Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ig-aqWKe4Kl0 for ; Sat, 24 Nov 2018 00:21:19 +0000 (UTC) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by whitealder.osuosl.org (Postfix) with ESMTPS id 6ACFC887E0 for ; Sat, 24 Nov 2018 00:21:19 +0000 (UTC) From: NeilBrown Date: Sat, 24 Nov 2018 11:21:09 +1100 Subject: Re: [PATCH v6 00/33] staging: mt7621-pci: Parse ports info from DT and other minor cleanups In-Reply-To: <20181112054444.GA16266@foobar> References: <1541328599-18396-1-git-send-email-sergio.paracuellos@gmail.com> <20181111193552.GA17578@kroah.com> <87zhufuwcl.fsf@notabene.neil.brown.name> <20181112054444.GA16266@foobar> Message-ID: <87lg5j9vgq.fsf@notabene.neil.brown.name> MIME-Version: 1.0 List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7133902143460164314==" Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Sergio Paracuellos Cc: Greg KH , driverdev-devel@linuxdriverproject.org --===============7133902143460164314== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Mon, Nov 12 2018, Sergio Paracuellos wrote: > On Mon, Nov 12, 2018 at 08:40:10AM +1100, NeilBrown wrote: >> On Sun, Nov 11 2018, Greg KH wrote: >>=20 >> > On Sun, Nov 04, 2018 at 11:49:26AM +0100, Sergio Paracuellos wrote: >> >> This patch series parse remaining port info from device tree storing >> >> it in mt7621_pcie_port struct created for this. It also performs a lot >> >> of cleanups to get the driver in a good shape to give it a try to get >> >> mainlined. All of this changes are only compile-tested. >> > >> > Given the lack of responses here, I guess I'll just merge this and see >> > what happens :) >>=20 >> Sounds like a good plan. >> I had meant to look at it this past weekend, but ran out of time. >> It is a bit awkward for me to test on mainline at the moment as >>=20 >> # first bad commit: [f8c55dc6e828324fc58c0bb32d72a5a4041d1c3b] MIPS: use= generic dma noncoherent ops for simple noncoherent platforms >>=20 >> breaks mmc on my hardware, and my root filesystem is on mmc. >>=20 >> But I should still be able to get it tested sometime in the next couple >> of weeks, and will provide feedback once I have it. > > Thanks, Neil. Please, let me know if I can help in any way. I've got all the way to the end of the series and with the fixes that I've already posted, my device still works. There are lots of nice clean-ups in there - thanks! I didn't review them very closely as I was mostly focused on testing but what I saw generally looked nice. For the clock issue, I would just make a missing driver non-fatal. clk_enable() is a no-op on ralink-mips, and I'm not sure that clk_prepare does much either. Handling the reset issue is a bit harder. It seems that most bits in the reset register are 1=3Dassert 0=3Ddeassert but that on some chips, the three PCI reset lines are inverted. It would be easiest to put a quirk in arch/mips/ralink/reset.c=20 to check the CHIP_REV for the three lines and invert. It might be cleaner to add some information to devicetree, but I cannot easily find any precedent for that. BTW, rather than calling reset_control_deassert(port->pcie_rst); reset_control_assert(port->pcie_rst); maybe we should reset_control_reset(port->pcie_rst); and not worry about a delay. Are you OK to submit patches to address the various issues that I found? Thanks a lot, NeilBrown --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEG8Yp69OQ2HB7X0l6Oeye3VZigbkFAlv4mXYACgkQOeye3VZi gbkhaBAAo3oGcZ0B1zVR2ejiM15Mt20peubqphnQ57urDEZhXhPjvha8hWptwj30 YRq4IVxsZtlx7cl3KpeWpAW7uFLUeC2sz0CNnvzxlNCHpWnckHQ1erG+7tgLeLEb eOJmwDewuzJCReMgZ0MmBxQTZUNDhEAgIU6qY6N9lFHnyzlCPyglfJMtDuNzyFYM OOyj9RBpWT52qGr/nuiT5XHOsYjolFtRCxzCNB4vK202UF3l1pp5hAofm1fEoGI3 VZxT/yAvkRSzgG/qTjH0fOTKdlNoI68MFxIEZwv8Fe3TUd5xSQhgedsSJ6Zgqubr 6grmgQtF1Qm/gsVl40+ikjDk1cHqRXWqLAqN/h/ybwHTQfexE7FTEn0dCCtgSMNZ MIP3FcayZRJWIP6G3ovPFv70gfJ3ixIsZImtPgILx9p7L5Cw4/AVRS/BjV0d9G3H aULihtnDQVhbQak8P795L470rKXV2EB7w38YGH7L5mt5bl91vNdX3G594w4RchAM 7Ma6A96QUV1GTo2ehDO3KU5/kdwGh5RaEs8yLZkTmD7a+VClBQ1AG+8CxO6s9jUw ez1gR0O0A5ZzoLQgiq6b01ttBJQ0T6CXXeUZ1/bSoHYSf4vl0lvV1Vg2wHikzENT rhHvQPP/Inb4ApBNur3502NN6+4EIViGaqCv6EL+SqfaIRkFcGg= =WD2W -----END PGP SIGNATURE----- --=-=-=-- --===============7133902143460164314== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel --===============7133902143460164314==--