From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.toke.dk ([52.28.52.200]:46581 "EHLO mail.toke.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751046AbeEPJZI (ORCPT ); Wed, 16 May 2018 05:25:08 -0400 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Dan Carpenter , Johannes Berg Cc: linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] cfg80211: Use correct GFP_ mask in cfg80211_del_sta_sinfo() In-Reply-To: <20180516084836.GB23043@mwanda> References: <20180516084836.GB23043@mwanda> Date: Wed, 16 May 2018 11:25:07 +0200 Message-ID: <87lgckymto.fsf@toke.dk> (sfid-20180516_112514_083132_1AAED641) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Dan Carpenter writes: > Smatch complains that we should use the passed in "gfp" instead of hard > coding GFP_KERNEL. I looked at some of the callers and this would > probably be a bug for rtw_cfg80211_indicate_sta_disassoc() which uses > GFP_ATOMIC and a NULL "sinfo". > > Fixes: 52539ca89f36 ("cfg80211: Expose TXQ stats and parameters to usersp= ace") > Signed-off-by: Dan Carpenter Ah, right, didn't notice that that was supposed to be a gfp value. Thanks for the fix :) Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen -Toke From mboxrd@z Thu Jan 1 00:00:00 1970 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Date: Wed, 16 May 2018 09:25:07 +0000 Subject: Re: [PATCH] cfg80211: Use correct GFP_ mask in cfg80211_del_sta_sinfo() Message-Id: <87lgckymto.fsf@toke.dk> List-Id: References: <20180516084836.GB23043@mwanda> In-Reply-To: <20180516084836.GB23043@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Dan Carpenter , Johannes Berg Cc: linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org Dan Carpenter writes: > Smatch complains that we should use the passed in "gfp" instead of hard > coding GFP_KERNEL. I looked at some of the callers and this would > probably be a bug for rtw_cfg80211_indicate_sta_disassoc() which uses > GFP_ATOMIC and a NULL "sinfo". > > Fixes: 52539ca89f36 ("cfg80211: Expose TXQ stats and parameters to userspace") > Signed-off-by: Dan Carpenter Ah, right, didn't notice that that was supposed to be a gfp value. Thanks for the fix :) Acked-by: Toke Høiland-Jørgensen -Toke