From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751342AbeEBL7E (ORCPT ); Wed, 2 May 2018 07:59:04 -0400 Received: from mail02.asahi-net.or.jp ([202.224.55.14]:58597 "EHLO mail02.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750936AbeEBL67 (ORCPT ); Wed, 2 May 2018 07:58:59 -0400 Date: Wed, 02 May 2018 20:53:39 +0900 Message-ID: <87lgd2tgsc.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Rob Herring Cc: "linux-kernel@vger.kernel.org" , "moderated list:H8/300 ARCHITECTURE" Subject: Re: [PATCH] h8300: switch to NO_BOOTMEM In-Reply-To: References: <20180316213306.20424-1-robh@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/24.5 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 02 May 2018 11:33:41 +0900, Rob Herring wrote: > > On Fri, Mar 16, 2018 at 4:33 PM, Rob Herring wrote: > > Commit 0fa1c579349f ("of/fdt: use memblock_virt_alloc for early alloc") > > inadvertently switched the DT unflattening allocations from memblock to > > bootmem which doesn't work because the unflattening happens before > > bootmem is initialized. Swapping the order of bootmem init and > > unflattening could also fix this, but removing bootmem is desired. So > > enable NO_BOOTMEM on h8300 like other architectures have done. > > > > Fixes: 0fa1c579349f ("of/fdt: use memblock_virt_alloc for early alloc") > > Cc: Yoshinori Sato > > Cc: uclinux-h8-devel@lists.sourceforge.jp > > Signed-off-by: Rob Herring > > --- > > I haven't seen any reports, but 4.16 is likely broken. This is compile > > tested only. > > > > Moving unflattening after bootmem_init should also work if a smaller > > change for 4.16 is desired. > > Ping! Someone going to pick this up? > > Rob Sorry. I looked out. Please wait several days to confirm. -- Yosinori Sato