From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753630AbeBGJ2y (ORCPT ); Wed, 7 Feb 2018 04:28:54 -0500 Received: from smtp04.smtpout.orange.fr ([80.12.242.126]:23269 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753314AbeBGJ2w (ORCPT ); Wed, 7 Feb 2018 04:28:52 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Wed, 07 Feb 2018 10:28:50 +0100 X-ME-IP: 86.201.132.185 From: Robert Jarzmik To: Ulf Magnusson Cc: Linux Kernel Mailing List , perex@perex.cz, tiwai@suse.com, broonie@kernel.org, alsa-devel@alsa-project.org, Linux Kbuild mailing list , tfiga@chromium.org, paul.burton@mips.com, Marek Szyprowski , Hans-Christian Noren Egtvedt , Linus Walleij , vgupta@synopsys.com, mgorman@techsingularity.net, hch@lst.de, mina86@mina86.com, robh@kernel.org, sboyd@codeaurora.org, paulus@ozlabs.org, will.deacon@arm.com, Tony Lindgren , Nicholas Piggin , Masahiro Yamada , Palmer Dabbelt , Albert Ou , linux-riscv@lists.infradead.org Subject: Re: [PATCH 00/20] Remove references to undefined symbols and fix two potential bugs References: <20180205012146.23981-1-ulfalizer@gmail.com> X-URL: http://belgarath.falguerolles.org/ Date: Wed, 07 Feb 2018 10:28:11 +0100 In-Reply-To: (Ulf Magnusson's message of "Mon, 5 Feb 2018 03:08:24 +0100") Message-ID: <87lgg587ys.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ulf Magnusson writes: > The symbol AC97_BUS_NEW in sound/ac97/Kconfig selects the globally > undefined symbol AC97. > > It doesn't seem to simply be a misspelling of AC97_BUS, because then > the dependencies of AC97_BUS_COMPAT would be impossible to satisfy. You're correct. I don't know what happened to me when coding this, but you can safely remove this useless select statement. Cheers. -- Robert From mboxrd@z Thu Jan 1 00:00:00 1970 From: robert.jarzmik@free.fr (Robert Jarzmik) Date: Wed, 07 Feb 2018 10:28:11 +0100 Subject: [PATCH 00/20] Remove references to undefined symbols and fix two potential bugs In-Reply-To: (Ulf Magnusson's message of "Mon, 5 Feb 2018 03:08:24 +0100") References: <20180205012146.23981-1-ulfalizer@gmail.com> Message-ID: <87lgg587ys.fsf@belgarion.home> To: linux-riscv@lists.infradead.org List-Id: linux-riscv.lists.infradead.org Ulf Magnusson writes: > The symbol AC97_BUS_NEW in sound/ac97/Kconfig selects the globally > undefined symbol AC97. > > It doesn't seem to simply be a misspelling of AC97_BUS, because then > the dependencies of AC97_BUS_COMPAT would be impossible to satisfy. You're correct. I don't know what happened to me when coding this, but you can safely remove this useless select statement. Cheers. -- Robert