All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bjørn Mork" <bjorn@mork.no>
To: Aleksander Morgado <aleksander@aleksander.es>
Cc: Daniele Palmas <dnlplm@gmail.com>,
	"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/1] drivers: net: usb: qmi_wwan: add QMI_QUIRK_SET_DTR for Telit PID 0x1201
Date: Thu, 20 Apr 2017 11:02:08 +0200	[thread overview]
Message-ID: <87lgqva1v3.fsf@miraculix.mork.no> (raw)
In-Reply-To: <CAAP7ucL0KLCxVSaO4Vf0LH=T7vRCtm5R2p9VFov+5V0OJF8Xcg@mail.gmail.com> (Aleksander Morgado's message of "Wed, 19 Apr 2017 20:32:25 +0200")

Aleksander Morgado <aleksander@aleksander.es> writes:

> I'm just running --dms-get-operating-mode multiple times, and getting
> errors frequently:

Could you retry that with cdc-wdm debugging enabled (e.g.
"echo 'module cdc_wdm +fp' > /sys/kernel/debug/dynamic_debug/control")
and something like this:


diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c
index 8fda45a45bd3..c0f25ace9fc6 100644
--- a/drivers/usb/class/cdc-wdm.c
+++ b/drivers/usb/class/cdc-wdm.c
@@ -211,6 +211,8 @@ static void wdm_in_callback(struct urb *urb)
 		}
 	}
 
+	dev_dbg(&desc->intf->dev, "rerr=%d, status=%d, length=%d, resp_count=%d\n", desc->rerr, status, length, desc->resp_count);
+
 	/*
 	 * Handling devices with the WDM_DRAIN_ON_OPEN flag set:
 	 * If desc->resp_count is unset, then the urb was submitted
@@ -516,6 +518,9 @@ static ssize_t wdm_read
 		return -ERESTARTSYS;
 
 	cntr = ACCESS_ONCE(desc->length);
+
+	dev_dbg(&desc->intf->dev, "rerr=%d, length=%d\n", desc->rerr, cntr);
+
 	if (cntr == 0) {
 		desc->read = 0;
 retry:



And/or a usbmon dump?  That would be.probably show us the sequence of
events leading to this problem.

Desperately trying to figure out some other way to solve the issue that
commit  833415a3e781 ("cdc-wdm: fix "out-of-sync" due to missing
notifications") was supposed to fix....



Bjørn

  parent reply	other threads:[~2017-04-20  9:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-10 15:34 [PATCH 1/1] drivers: net: usb: qmi_wwan: add QMI_QUIRK_SET_DTR for Telit PID 0x1201 Daniele Palmas
2017-04-13 16:36 ` David Miller
2017-04-19 17:28 ` Bjørn Mork
     [not found]   ` <87efwob92t.fsf-3F4PFWf5pNjpjLOzFPqGjWGXanvQGlWp@public.gmane.org>
2017-04-19 18:32     ` Aleksander Morgado
     [not found]       ` <CAAP7ucL0KLCxVSaO4Vf0LH=T7vRCtm5R2p9VFov+5V0OJF8Xcg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-19 19:39         ` Bjørn Mork
2017-04-20  9:02       ` Bjørn Mork [this message]
2017-04-21 10:30   ` Daniele Palmas
2017-04-21 12:22     ` Daniele Palmas
2017-04-21 13:02       ` Bjørn Mork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lgqva1v3.fsf@miraculix.mork.no \
    --to=bjorn@mork.no \
    --cc=aleksander@aleksander.es \
    --cc=dnlplm@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.