From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH v4] drm/i915: Move breadcrumbs irq_posted up a level to engine Date: Tue, 24 Jan 2017 17:45:30 +0200 Message-ID: <87lgu0a2cl.fsf@gaia.fi.intel.com> References: <20170124110009.28947-3-chris@chris-wilson.co.uk> <20170124151805.26146-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id E1D676E804 for ; Tue, 24 Jan 2017 15:46:11 +0000 (UTC) In-Reply-To: <20170124151805.26146-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gSW4gdGhl IG5leHQgcGF0Y2gsIHdlIHdpbGwgdXNlIHRoZSBpcnFfcG9zdGVkIHRlY2huaXF1ZSBmb3IgYW5v dGhlcgo+IGVuZ2luZSBpbnRlcnJ1cHQsIHJhdGhlciB0aGFuIHVzZSB0d28gbWVtYmVycyBmb3Ig dGhlIGF0b21pYyB1cGRhdGVzLCB3ZQo+IGNhbiB1c2UgdHdvIGJpdHMgb2Ygb25lIGluc3RlYWQu IEZpcnN0LCB3ZSBuZWVkIHRvIHVwZGF0ZSB0aGUKPiBicmVhZGNydW1icyB0byB1c2UgdGhlIG5l dyBjb21tb24gZW5naW5lLT5pcnFfcG9zdGVkLgo+Cj4gdjI6IFVzZSBzZXRfYml0KCkgcmF0aGVy IHRoYW4gX19zZXRfYml0KCkgdG8gZW5zdXJlIGF0b21pY2l0eSB3aXRoCj4gcmVzcGVjdCB0byBv dGhlciBiaXRzIGluIHRoZSBtYXNrCj4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNo cmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFs YUBpbnRlbC5jb20+Cj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5j b20KTWlzc2luZyAnPicgaW4gdGhlIGVuZCBvZiBsaW5lCgpSZXZpZXdlZC1ieTogTWlrYSBLdW9w cGFsYSA8bWlrYS5rdW9wcGFsYUBpbnRlbC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2Rydi5oICAgICAgICAgIHwgMiArLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2lycS5jICAgICAgICAgIHwgMiArLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9i cmVhZGNydW1icy5jIHwgOSArKysrLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf cmluZ2J1ZmZlci5oICB8IDQgKysrLQo+ICA0IGZpbGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygr KSwgOCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+IGluZGV4IGNjYjRm YjgwNGZjYS4uNjUyZTQwYzZjYTQwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gQEAg LTM5NjQsNyArMzk2NCw3IEBAIF9faTkxNV9yZXF1ZXN0X2lycV9jb21wbGV0ZShzdHJ1Y3QgZHJt X2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSkKPiAgCSAqLwo+ICAJaWYgKGVuZ2luZS0+aXJxX3NlcW5v X2JhcnJpZXIgJiYKPiAgCSAgICByY3VfYWNjZXNzX3BvaW50ZXIoZW5naW5lLT5icmVhZGNydW1i cy5pcnFfc2Vxbm9fYmgpID09IGN1cnJlbnQgJiYKPiAtCSAgICBjbXB4Y2hnX3JlbGF4ZWQoJmVu Z2luZS0+YnJlYWRjcnVtYnMuaXJxX3Bvc3RlZCwgMSwgMCkpIHsKPiArCSAgICB0ZXN0X2FuZF9j bGVhcl9iaXQoRU5HSU5FX0lSUV9CUkVBRENSVU1CLCAmZW5naW5lLT5pcnFfcG9zdGVkKSkgewo+ ICAJCXN0cnVjdCB0YXNrX3N0cnVjdCAqdHNrOwo+ICAKPiAgCQkvKiBUaGUgb3JkZXJpbmcgb2Yg aXJxX3Bvc3RlZCB2ZXJzdXMgYXBwbHlpbmcgdGhlIGJhcnJpZXIKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf aXJxLmMKPiBpbmRleCA2ZmVmYzM0ZWY2MDIuLjdlMDg3YzM0NDI2NSAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9pcnEuYwo+IEBAIC0xMDMzLDcgKzEwMzMsNyBAQCBzdGF0aWMgdm9pZCBpcm9ubGFr ZV9ycHNfY2hhbmdlX2lycV9oYW5kbGVyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp dikKPiAgCj4gIHN0YXRpYyB2b2lkIG5vdGlmeV9yaW5nKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3Mg KmVuZ2luZSkKPiAgewo+IC0Jc21wX3N0b3JlX21iKGVuZ2luZS0+YnJlYWRjcnVtYnMuaXJxX3Bv c3RlZCwgdHJ1ZSk7Cj4gKwlzZXRfYml0KEVOR0lORV9JUlFfQlJFQURDUlVNQiwgJmVuZ2luZS0+ aXJxX3Bvc3RlZCk7Cj4gIAlpZiAoaW50ZWxfZW5naW5lX3dha2V1cChlbmdpbmUpKQo+ICAJCXRy YWNlX2k5MTVfZ2VtX3JlcXVlc3Rfbm90aWZ5KGVuZ2luZSk7Cj4gIH0KPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYnJlYWRjcnVtYnMuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2JyZWFkY3J1bWJzLmMKPiBpbmRleCBjNmZhNzcxNzc2MTUuLjZiMjRmMjU0 NGI2YiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9icmVhZGNydW1i cy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYnJlYWRjcnVtYnMuYwo+IEBA IC04MSw3ICs4MSw3IEBAIHN0YXRpYyB2b2lkIGlycV9lbmFibGUoc3RydWN0IGludGVsX2VuZ2lu ZV9jcyAqZW5naW5lKQo+ICAJICogd2Ugc3RpbGwgbmVlZCB0byBmb3JjZSB0aGUgYmFycmllciBi ZWZvcmUgcmVhZGluZyB0aGUgc2Vxbm8sCj4gIAkgKiBqdXN0IGluIGNhc2UuCj4gIAkgKi8KPiAt CWVuZ2luZS0+YnJlYWRjcnVtYnMuaXJxX3Bvc3RlZCA9IHRydWU7Cj4gKwlzZXRfYml0KEVOR0lO RV9JUlFfQlJFQURDUlVNQiwgJmVuZ2luZS0+aXJxX3Bvc3RlZCk7Cj4gIAo+ICAJLyogQ2FsbGVy IGRpc2FibGVzIGludGVycnVwdHMgKi8KPiAgCXNwaW5fbG9jaygmZW5naW5lLT5pOTE1LT5pcnFf bG9jayk7Cj4gQEAgLTk1LDggKzk1LDYgQEAgc3RhdGljIHZvaWQgaXJxX2Rpc2FibGUoc3RydWN0 IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAJc3Bpbl9sb2NrKCZlbmdpbmUtPmk5MTUtPmly cV9sb2NrKTsKPiAgCWVuZ2luZS0+aXJxX2Rpc2FibGUoZW5naW5lKTsKPiAgCXNwaW5fdW5sb2Nr KCZlbmdpbmUtPmk5MTUtPmlycV9sb2NrKTsKPiAtCj4gLQllbmdpbmUtPmJyZWFkY3J1bWJzLmly cV9wb3N0ZWQgPSBmYWxzZTsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgX19pbnRlbF9icmVhZGNy dW1ic19lbmFibGVfaXJxKHN0cnVjdCBpbnRlbF9icmVhZGNydW1icyAqYikKPiBAQCAtMjU3LDcg KzI1NSw4IEBAIHN0YXRpYyBib29sIF9faW50ZWxfZW5naW5lX2FkZF93YWl0KHN0cnVjdCBpbnRl bF9lbmdpbmVfY3MgKmVuZ2luZSwKPiAgCQkJICogaW4gY2FzZSB0aGUgc2Vxbm8gcGFzc2VkLgo+ ICAJCQkgKi8KPiAgCQkJX19pbnRlbF9icmVhZGNydW1ic19lbmFibGVfaXJxKGIpOwo+IC0JCQlp ZiAoUkVBRF9PTkNFKGItPmlycV9wb3N0ZWQpKQo+ICsJCQlpZiAodGVzdF9iaXQoRU5HSU5FX0lS UV9CUkVBRENSVU1CLAo+ICsJCQkJICAgICAmZW5naW5lLT5pcnFfcG9zdGVkKSkKPiAgCQkJCXdh a2VfdXBfcHJvY2Vzcyh0b193YWl0KG5leHQpLT50c2spOwo+ICAJCX0KPiAgCj4gQEAgLTYxMCw3 ICs2MDksNyBAQCB2b2lkIGludGVsX2VuZ2luZV9yZXNldF9icmVhZGNydW1icyhzdHJ1Y3QgaW50 ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gIAlpZiAoaW50ZWxfZW5naW5lX2hhc193YWl0ZXIoZW5n aW5lKSkgewo+ICAJCWItPnRpbWVvdXQgPSB3YWl0X3RpbWVvdXQoKTsKPiAgCQlfX2ludGVsX2Jy ZWFkY3J1bWJzX2VuYWJsZV9pcnEoYik7Cj4gLQkJaWYgKFJFQURfT05DRShiLT5pcnFfcG9zdGVk KSkKPiArCQlpZiAodGVzdF9iaXQoRU5HSU5FX0lSUV9CUkVBRENSVU1CLCAmZW5naW5lLT5pcnFf cG9zdGVkKSkKPiAgCQkJd2FrZV91cF9wcm9jZXNzKGItPmZpcnN0X3dhaXQtPnRzayk7Cj4gIAl9 IGVsc2Ugewo+ICAJCS8qIHNhbml0aXplIHRoZSBJTVIgYW5kIHVubWFzayBhbnkgYXV4aWxpYXJ5 IGludGVycnVwdHMgKi8KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf cmluZ2J1ZmZlci5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4g aW5kZXggZGJkMzI1ODVmMjdhLi5hOWVhODRlYTMxNTUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gQEAgLTIxMSw2ICsyMTEsOSBAQCBzdHJ1Y3QgaW50ZWxf ZW5naW5lX2NzIHsKPiAgCj4gIAlzdHJ1Y3QgaW50ZWxfcmVuZGVyX3N0YXRlICpyZW5kZXJfc3Rh dGU7Cj4gIAo+ICsJdW5zaWduZWQgbG9uZyBpcnFfcG9zdGVkOwo+ICsjZGVmaW5lIEVOR0lORV9J UlFfQlJFQURDUlVNQiAwCj4gKwo+ICAJLyogUmF0aGVyIHRoYW4gaGF2ZSBldmVyeSBjbGllbnQg d2FpdCB1cG9uIGFsbCB1c2VyIGludGVycnVwdHMsCj4gIAkgKiB3aXRoIHRoZSBoZXJkIHdha2lu ZyBhZnRlciBldmVyeSBpbnRlcnJ1cHQgYW5kIGVhY2ggZG9pbmcgdGhlCj4gIAkgKiBoZWF2eXdl aWdodCBzZXFubyBkYW5jZSwgd2UgZGVsZWdhdGUgdGhlIHRhc2sgKG9mIGJlaW5nIHRoZQo+IEBA IC0yMjksNyArMjMyLDYgQEAgc3RydWN0IGludGVsX2VuZ2luZV9jcyB7Cj4gIAkgKi8KPiAgCXN0 cnVjdCBpbnRlbF9icmVhZGNydW1icyB7Cj4gIAkJc3RydWN0IHRhc2tfc3RydWN0IF9fcmN1ICpp cnFfc2Vxbm9fYmg7IC8qIGJoIGZvciBpbnRlcnJ1cHRzICovCj4gLQkJYm9vbCBpcnFfcG9zdGVk Owo+ICAKPiAgCQlzcGlubG9ja190IGxvY2s7IC8qIHByb3RlY3RzIHRoZSBsaXN0cyBvZiByZXF1 ZXN0czsgaXJxc2FmZSAqLwo+ICAJCXN0cnVjdCByYl9yb290IHdhaXRlcnM7IC8qIHNvcnRlZCBi eSByZXRpcmVtZW50LCBwcmlvcml0eSAqLwo+IC0tIAo+IDIuMTEuMAo+Cj4gX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBs aXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=