From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758285AbcHYLcb (ORCPT <rfc822;w@1wt.eu>);
        Thu, 25 Aug 2016 07:32:31 -0400
Received: from ozlabs.org ([103.22.144.67]:58566 "EHLO ozlabs.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751675AbcHYLca (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 25 Aug 2016 07:32:30 -0400
From: Rusty Russell <rusty@rustcorp.com.au>
To: Jiri Kosina <jikos@kernel.org>, Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Jessica Yu <jeyu@redhat.com>, Miroslav Benes <mbenes@suse.cz>,
        Petr Mladek <pmladek@suse.com>, linux-kernel@vger.kernel.org,
        live-patching@vger.kernel.org, Chunyu Hu <chuhu@redhat.com>
Subject: Re: [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific
In-Reply-To: <alpine.LNX.2.00.1608250252380.22028@cbobk.fhfr.pm>
References: <c6a606f6c1e291c6c292403ade24833801ad243d.1472074373.git.jpoimboe@redhat.com> <alpine.LNX.2.00.1608250252380.22028@cbobk.fhfr.pm>
User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu)
Date: Thu, 25 Aug 2016 13:44:10 +0930
Message-ID: <87lgzleb8t.fsf@rustcorp.com.au>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Jiri Kosina <jikos@kernel.org> writes:
> On Wed, 24 Aug 2016, Josh Poimboeuf wrote:
>
>> There's no reliable way to determine which module tainted the kernel
>> with CONFIG_LIVEPATCH.  For example, /sys/module/<klp module>/taint
>> doesn't report it.  Neither does the "mod -t" command in the crash tool.
>> 
>> Make it crystal clear who the guilty party is by converting
>> CONFIG_LIVEPATCH to a module taint flag.
>> 
>> This changes the behavior a bit: now the the flag gets set when the
>> module is loaded, rather than when it's enabled.
>> 
>> Reviewed-by: Chunyu Hu <chuhu@redhat.com>
>> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
>
> I like this change.
>
> Rusty, in case you're okay with it as well, could you please either 
> provide your Ack so that I could take it through livepatching.git? 
> Alternatively, if you prefer to merge this through your tree, please feel 
> free to add

Happy to leave it to you :)

Acked-by: Rusty Russell <rusty@rustcorp.com.au>

Thanks,
Rusty.