From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753651AbcHRHSL (ORCPT ); Thu, 18 Aug 2016 03:18:11 -0400 Received: from mga02.intel.com ([134.134.136.20]:33319 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751092AbcHRHSJ (ORCPT ); Thu, 18 Aug 2016 03:18:09 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,537,1464678000"; d="asc'?scan'208";a="1027508547" From: Felipe Balbi To: Baolin Wang , gregkh@linuxfoundation.org, mathias.nyman@linux.intel.com Cc: mathias.nyman@intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, broonie@kernel.org, baolin.wang@linaro.org Subject: Re: [PATCH 1/4] usb: host: xhci: Move the xhci quirks checking to the right place In-Reply-To: References: User-Agent: Notmuch/0.22.1+63~g994277e (https://notmuchmail.org) Emacs/25.1.1 (x86_64-pc-linux-gnu) Date: Thu, 18 Aug 2016 10:17:11 +0300 Message-ID: <87lgzu5yx4.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Baolin Wang writes: > It will reset the xhci quirks in xhci_gen_setup() function when xhci try = to > add one hcd, thus we need to move the XHCI_LPM_SUPPORT quirk checking aft= er > adding hcd. > > Signed-off-by: Baolin Wang > --- > drivers/usb/host/xhci-plat.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c > index 1f3f981..e2e2487 100644 > --- a/drivers/usb/host/xhci-plat.c > +++ b/drivers/usb/host/xhci-plat.c > @@ -223,10 +223,6 @@ static int xhci_plat_probe(struct platform_device *p= dev) > goto disable_clk; > } >=20=20 > - if ((node && of_property_read_bool(node, "usb3-lpm-capable")) || > - (pdata && pdata->usb3_lpm_capable)) > - xhci->quirks |=3D XHCI_LPM_SUPPORT; > - > if (HCC_MAX_PSA(xhci->hcc_params) >=3D 4) > xhci->shared_hcd->can_do_streams =3D 1; >=20=20 > @@ -250,6 +246,10 @@ static int xhci_plat_probe(struct platform_device *p= dev) > if (ret) > goto dealloc_usb2_hcd; >=20=20 > + if ((node && of_property_read_bool(node, "usb3-lpm-capable")) || > + (pdata && pdata->usb3_lpm_capable)) > + xhci->quirks |=3D XHCI_LPM_SUPPORT; > + Mathias, any comments here? > return 0; >=20=20 >=20=20 > --=20 > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJXtWD3AAoJEIaOsuA1yqRERCEP/R0VNSkmnQ5W8NtXKuQaHoQ9 vewp0N+0Ku8OtuG2wF6HKcElP40DLvNgJPKg4YQfE77I/hjz3EZlRmTzUhjTqCeY /NFdmDGxuUL4bMRGReImaGi/OinoxLV5b0S78NKPyEBbAt2itg02n1zSZNyZKNty q7JlUGSxFIwLV0MFC+WsHWf5VbGU2/ldjmRXtx6kTCAWGE7ryIZACRmpm467jegN o6yyzmfq3hv8teuDr9QBucoxj58EAxnC33ETnvNBMEj0ozyfaOFFVNm6YsrfI4eN WiVJ651k3nYRYRRBBEB8R+KfcW1nW0kzZlOE4H84w62qmrDNl4u98WjIN9fl43Ft sorxP9KrZOcyv2sNuwvloGZQm/1/gg3SYMZnGpjePCGrrkpvOLUjX/b7xN2+13N5 b+D/s910lYzrgctcYiB29N309ew1Bd5c9+20ppLpOmyhRvQXdN9lxgUbESwJRV2B wiGHr6xpMB3SouVOS/5BUQtWXhy+WuW1t2rp+ZAtUXodejXz5+Fzra6b0uidrRFM V7T0SCwFp5mSRNsgCw0fPn+9TqBevi/XlPWn32+UxPaqVg6KAEBdGng6+95LEKaa TveABnJYdgpLsgzyi+Nlxo05Yu5kqrpppwVMh7Ci4dkQMwEahyrLoMGJ/cVTutt6 jY9XiDtLwPhKm2TEY21P =xiKE -----END PGP SIGNATURE----- --=-=-=--