From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51230) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZACLX-00005E-DL for qemu-devel@nongnu.org; Wed, 01 Jul 2015 03:22:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZACLU-0005iu-4U for qemu-devel@nongnu.org; Wed, 01 Jul 2015 03:22:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59659) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZACLT-0005im-VJ for qemu-devel@nongnu.org; Wed, 01 Jul 2015 03:22:12 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id E614119CF48 for ; Wed, 1 Jul 2015 07:22:10 +0000 (UTC) From: Juan Quintela In-Reply-To: <5581CE4C.90700@redhat.com> (Eric Blake's message of "Wed, 17 Jun 2015 13:45:16 -0600") References: <1434505833-11234-1-git-send-email-quintela@redhat.com> <1434505833-11234-11-git-send-email-quintela@redhat.com> <5581CE4C.90700@redhat.com> Date: Wed, 01 Jul 2015 09:22:08 +0200 Message-ID: <87lhf04a1r.fsf@neno.neno> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 10/11] migration: create migration event Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: amit.shah@redhat.com, qemu-devel@nongnu.org Eric Blake wrote: > On 06/16/2015 07:50 PM, Juan Quintela wrote: >> We have one argument that tells us what event has happened. >> >> Signed-off-by: Juan Quintela >> >> X3 >> >> Signed-off-by: Juan Quintela > > Intentional double-S-o-b? No, merge artifact > >> --- >> docs/qmp/qmp-events.txt | 14 ++++++++++++++ >> migration/migration.c | 2 ++ >> qapi/event.json | 14 ++++++++++++++ >> 3 files changed, 30 insertions(+) >> > >> +Data: None. >> + >> + - "status": migration status >> + See MigrationStatus in ~/qapi-scheme.json for possible values > > s/scheme/schema/ fixed > > >> +++ b/qapi/event.json >> @@ -243,6 +243,20 @@ >> { 'event': 'SPICE_MIGRATE_COMPLETED' } >> >> ## >> +# @MIGRATION >> +# >> +# Emitted when a migration event happens >> +# >> +# @status: @MigrationStatus describing the current migration status. >> +# If this field is not returned, no migration process >> +# has been initiated > > Drop this second sentence. 'status' is emitted unconditionally (it is > not marked optional). > > With those two changes, > Reviewed-by: Eric Blake fixed