From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbQwc-0005o5-3e for qemu-devel@nongnu.org; Fri, 27 Mar 2015 05:52:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YbQwV-0000W7-MY for qemu-devel@nongnu.org; Fri, 27 Mar 2015 05:52:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42432) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbQwV-0000W0-FK for qemu-devel@nongnu.org; Fri, 27 Mar 2015 05:52:43 -0400 From: Markus Armbruster References: <1427227433-5030-1-git-send-email-eblake@redhat.com> <1427227433-5030-25-git-send-email-eblake@redhat.com> Date: Fri, 27 Mar 2015 10:52:37 +0100 In-Reply-To: <1427227433-5030-25-git-send-email-eblake@redhat.com> (Eric Blake's message of "Tue, 24 Mar 2015 14:03:49 -0600") Message-ID: <87lhiircm2.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v5 24/28] qapi: Merge UserDefTwo and UserDefNested in tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, lcapitulino@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, wenchaoqemu@gmail.com Eric Blake writes: > In the testsuite, UserDefTwo and UserDefNested were identical > types other than the member names. Reduce code duplication by > having just one type, and choose names that also favor reuse. > This will also make it easier for a later patch to get rid of > inline nested types in QAPI; it means that the type is now boxed > instead of unboxed in C code, but has no difference to the QMP > wire protocol. I can't see a change from boxed to unboxed in this patch. Does the remark apply to the elimination of nested types? If yes, it's premature here. > When touching code to add new allocations, also > convert existing allocations to consistently prefer typesafe > g_new0 over g_malloc0. I can't see any change from g_malloc0() to g_new0(). Is this stale? > > Ensure that 'make check-qapi-schema check-unit' still passes. > > Signed-off-by: Eric Blake