From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43990)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@pond.sub.org>) id 1X0ALq-0007oI-48
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 10:08:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@pond.sub.org>) id 1X0ALg-0001nm-K8
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 10:08:34 -0400
Received: from oxygen.pond.sub.org ([2a01:4f8:201:233:1::3]:33342)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@pond.sub.org>) id 1X0ALg-0001ni-DU
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 10:08:24 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1403073840-32603-1-git-send-email-pbonzini@redhat.com>
	<1403073840-32603-24-git-send-email-pbonzini@redhat.com>
Date: Thu, 26 Jun 2014 16:08:21 +0200
In-Reply-To: <1403073840-32603-24-git-send-email-pbonzini@redhat.com> (Paolo
	Bonzini's message of "Wed, 18 Jun 2014 08:43:47 +0200")
Message-ID: <87lhsjepbe.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 2.1 23/36] qapi event: convert other
	BLOCK_JOB events
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, lcapitulino@redhat.com, qemu-devel@nongnu.org, wenchaoqemu@gmail.com

Paolo Bonzini <pbonzini@redhat.com> writes:

> From: Wenchao Xia <wenchaoqemu@gmail.com>
>
> Since BLOCK_JOB_COMPLETED, BLOCK_JOB_CANCELLED, BLOCK_JOB_READY are
> related, convert them in one patch. The block_job_event_* functions
> are used to keep encapsulation of BlockJob structure.
>
> Signed-off-by: Wenchao Xia <wenchaoqemu@gmail.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

This broke tests/qemu-iotests/040.  Apparently, the BLOCK_JOB_READY
event changed from

    {'timestamp': {'seconds': 1403791120, 'microseconds': 539716},
     'data': {'device': 'drive0',
               'type': 'commit',
               'speed': 0,
               'len': 1048576,
               'offset': 1048576},
     'event': 'BLOCK_JOB_READY'}

to just

    {'timestamp': {'seconds': 1403790920, 'microseconds': 123232},
     'data': {'device': 'drive0'},
     'event': 'BLOCK_JOB_READY'}

breaking qemu-iotests/040's tests of data/type and data/len.

Documentation of BLOCK_JOB_READY shows only data/device, before and
after this patch.

Suggests that

* Before this patch, code disagreed with docs, and qemu-iotests/040
  matched the code.

* After this patch, code matches docs, and qemu-iotests/040 matches
  neither.

Please advise.