From: Namhyung Kim <namhyung@kernel.org>
To: Stanislav Fomichev <stfomichev@yandex-team.ru>
Cc: a.p.zijlstra@chello.nl, paulus@samba.org, mingo@redhat.com,
acme@ghostprotocols.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] perf timechart: group figures and add title with details
Date: Tue, 29 Oct 2013 17:15:26 +0900 [thread overview]
Message-ID: <87li1c5w81.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <1382439412-23713-5-git-send-email-stfomichev@yandex-team.ru> (Stanislav Fomichev's message of "Tue, 22 Oct 2013 14:56:50 +0400")
On Tue, 22 Oct 2013 14:56:50 +0400, Stanislav Fomichev wrote:
> Add titles to figures so we can run SVG interactively in Firefox
> and check event details in the tooltips.
> This also aids exploring SVG with Inkscape because when user clicks on
> one part of logical figure, all parts are selected.
> It's also possible to read titles with Inkscape in the object details.
I have a trivial nitpick below, other than that
Acked-by: Namhyung Kim <namhyung@kernel.org>
>
> Signed-off-by: Stanislav Fomichev <stfomichev@yandex-team.ru>
> ---
> tools/perf/builtin-timechart.c | 4 ++--
> tools/perf/util/svghelper.c | 54 +++++++++++++++++++++++++++++++++++++++++-
> tools/perf/util/svghelper.h | 3 ++-
> 3 files changed, 57 insertions(+), 4 deletions(-)
>
> diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c
> index c7b30a8c7f3b..4d2ac96b75b1 100644
> --- a/tools/perf/builtin-timechart.c
> +++ b/tools/perf/builtin-timechart.c
> @@ -798,9 +798,9 @@ static void draw_process_bars(void)
> if (sample->type == TYPE_RUNNING)
> svg_sample(Y, sample->cpu, sample->start_time, sample->end_time);
For consistency, wouldn't it be better renaming svg_sample() to
svg_running()?
Thanks,
Namhyung
> if (sample->type == TYPE_BLOCKED)
> - svg_box(Y, sample->start_time, sample->end_time, "blocked");
> + svg_blocked(Y, sample->cpu, sample->start_time, sample->end_time);
> if (sample->type == TYPE_WAITING)
> - svg_waiting(Y, sample->start_time, sample->end_time);
> + svg_waiting(Y, sample->cpu, sample->start_time, sample->end_time);
> sample = sample->next;
> }
next prev parent reply other threads:[~2013-10-29 8:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 10:56 [PATCH 0/6] perf timechart improvements Stanislav Fomichev
2013-10-22 10:56 ` [PATCH 1/6] perf timechart: always try to print at least 15 tasks Stanislav Fomichev
2013-10-29 7:50 ` Namhyung Kim
2013-10-29 9:24 ` Stanislav Fomichev
2013-11-01 6:06 ` Namhyung Kim
2013-10-22 10:56 ` [PATCH 2/6] perf timechart: use proc_num to implement --power-only Stanislav Fomichev
2013-10-29 8:03 ` Namhyung Kim
2013-10-29 9:28 ` Stanislav Fomichev
2013-11-01 6:07 ` Namhyung Kim
2013-10-22 10:56 ` [PATCH 3/6] perf timechart: add support for displaying only tasks related data Stanislav Fomichev
2013-10-29 8:10 ` Namhyung Kim
2013-10-29 9:33 ` Stanislav Fomichev
2013-11-01 6:10 ` Namhyung Kim
2013-10-22 10:56 ` [PATCH 4/6] perf timechart: group figures and add title with details Stanislav Fomichev
2013-10-29 8:15 ` Namhyung Kim [this message]
2013-10-29 9:35 ` Stanislav Fomichev
2013-10-22 10:56 ` [PATCH 5/6] perf timechart: add support for -P and -T in timechart recording Stanislav Fomichev
2013-10-29 8:27 ` Namhyung Kim
2013-10-29 9:51 ` Stanislav Fomichev
2013-10-22 10:56 ` [PATCH 6/6] perf timechart: add backtrace support Stanislav Fomichev
2013-10-29 8:41 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87li1c5w81.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=stfomichev@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.