From: Chris Ball <cjb@laptop.org>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Seungwon Jeon <tgih.jun@samsung.com>,
linux-mmc@vger.kernel.org,
'Chander Kashyap' <chander.kashyap@linaro.org>
Subject: Re: [PATCH v2] mmc: sdhci-s3c: fix the card detection in runtime-pm
Date: Mon, 29 Oct 2012 17:16:47 -0400 [thread overview]
Message-ID: <87liepq8qo.fsf@octavius.laptop.org> (raw)
In-Reply-To: <201210191010.48776.heiko@sntech.de> ("Heiko \=\?utf-8\?Q\?St\?\= \=\?utf-8\?Q\?\=C3\=BCbner\=22's\?\= message of "Fri, 19 Oct 2012 10:10:48 +0200")
Hi,
On Fri, Oct 19 2012, Heiko Stübner wrote:
> Am Freitag, 19. Oktober 2012, 10:04:14 schrieb Seungwon Jeon:
>> On Thursday, October 18, 2012, Heiko Stuebner <heiko@sntech.de>
>>
>> > If host clock is disabled, host cannot detect a card
>> > in case of using the internal or gpio card-detect for detection.
>> >
>> > Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
>> > Tested-by: Heiko Stuebner <heiko@sntech.de>
>> > ---
>> > I've added the SDHCI_CD_GPIO to the conditional. With this change it
>> > works on my machine. But I'm not sure if this would also be necessary
>> > for the external card detect.
>>
>> Card detection will be asserted out of host in case of using SDHCI_CD_GPIO.
>> Adding SDHCI_CD_GPIO to the conditional seems unnecessary.
>
> But it _was_ necessary :-) . Because only then did the problem go away. You
> might be right, that there exists a better solution for this, but something in
> the original patch is at least still missing to fix the problem.
Seungwon, what would you like to do here? (I'm unhappy taking a patch
with your name on it that's been modified in a way you disagree with.)
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2012-10-29 21:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 9:59 [PATCH] mmc: sdhci-s3c: fix the card detection in runtime-pm Seungwon Jeon
2012-10-18 11:02 ` [PATCH v2] " Heiko Stübner
2012-10-19 8:04 ` Seungwon Jeon
2012-10-19 8:10 ` Heiko Stübner
2012-10-29 21:16 ` Chris Ball [this message]
2012-10-29 22:37 ` Heiko Stübner
2012-10-30 3:54 ` Seungwon Jeon
2012-10-30 5:28 ` [PATCH v2 1/2] mmc: sdhci-s3c: ensure non-transaction of bus before clk_disable Seungwon Jeon
2012-11-07 19:34 ` Chris Ball
2013-01-22 10:48 ` [PATCH 2/2] mmc: block: don't start new request when the card is removed Seungwon Jeon
2013-02-01 5:25 ` Jaehoon Chung
2013-02-08 12:08 ` Konstantin Dorfman
2013-02-11 17:03 ` Chris Ball
2012-10-30 5:28 ` [PATCH v2 2/2] mmc: sdhci-s3c: fix the card detection in runtime-pm Seungwon Jeon
2012-11-07 19:36 ` Chris Ball
2012-11-09 10:41 ` [PATCH v3] mmc: sdhci-s3c: ensure non-transaction of bus before clk_disable Seungwon Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87liepq8qo.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=chander.kashyap@linaro.org \
--cc=heiko@sntech.de \
--cc=linux-mmc@vger.kernel.org \
--cc=tgih.jun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.