From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48928) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rv2gq-0008KW-B8 for qemu-devel@nongnu.org; Wed, 08 Feb 2012 03:15:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rv2gm-0004Ff-KE for qemu-devel@nongnu.org; Wed, 08 Feb 2012 03:15:44 -0500 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:37547) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rv2gm-0004FR-21 for qemu-devel@nongnu.org; Wed, 08 Feb 2012 03:15:40 -0500 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 8 Feb 2012 08:13:17 +1000 Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q188AJoo2736346 for ; Wed, 8 Feb 2012 19:10:20 +1100 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q188FIwa030953 for ; Wed, 8 Feb 2012 19:15:18 +1100 From: "Aneesh Kumar K.V" In-Reply-To: <1328647446-5452-1-git-send-email-meadori@codesourcery.com> References: <1328647446-5452-1-git-send-email-meadori@codesourcery.com> Date: Wed, 08 Feb 2012 13:45:15 +0530 Message-ID: <87liodivvw.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH v1 0/1] Allow the building of VirtFS to be disabled List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Meador Inge , qemu-devel@nongnu.org Cc: aliguori@us.ibm.com On Tue, 7 Feb 2012 14:44:05 -0600, Meador Inge wrote: > There have been reports [1, 2] where folks have had issues building > VirtFS and the virtio backend on older systems. I personally saw > problems due to the use of features (struct statfs f_frsize field, > fdopendir, O_NOATIME) in this code that are not available on much older > Linux systems. Given, the system I ran into this on is ancient (RH8 sysroot), > but I still need to build QEMU on it nonetheless. > > This patch adds a new configure option for disabling the building of > VirtFS all together. Tested by building with and without --disable-virtfs > on older (RH8 sysroot) and newer systems (x64 Fedora 16). > > [1] http://lists.nongnu.org/archive/html/qemu-devel/2011-12/msg00171.html > [2] http://lists.nongnu.org/archive/html/qemu-devel/2012-02/msg00404.html > > Meador Inge (1): > ./configure: add option for disabling VirtFS > > Makefile | 4 ++++ > configure | 16 +++++++++++++--- > 2 files changed, 17 insertions(+), 3 deletions(-) I like the patch because it help to get qemu build on platforms where the build failures are only due to virtfs. VirtFS do depend on some of the recent linux APIs, so sometime we do break build on old Linux distros. Anthony any objection here ? -aneesh