From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs Date: Thu, 16 Sep 2010 11:01:07 -0700 Message-ID: <87lj718t5o.fsf@deeprootsystems.com> References: <1284587799-9637-1-git-send-email-khilman@deeprootsystems.com> <1284587799-9637-2-git-send-email-khilman@deeprootsystems.com> <87sk19eneu.fsf@deeprootsystems.com> <4C92386F.2070600@ti.com> <87vd65bsfs.fsf@deeprootsystems.com> <4C924F6E.6040804@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pz0-f46.google.com ([209.85.210.46]:40721 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754401Ab0IPSBK (ORCPT ); Thu, 16 Sep 2010 14:01:10 -0400 Received: by pzk34 with SMTP id 34so416790pzk.19 for ; Thu, 16 Sep 2010 11:01:10 -0700 (PDT) In-Reply-To: (Santosh Shilimkar's message of "Thu, 16 Sep 2010 22:43:03 +0530") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Shilimkar, Santosh" Cc: "Menon, Nishanth" , Linus Walleij , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" "Shilimkar, Santosh" writes: >> -----Original Message----- >> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap- >> owner@vger.kernel.org] On Behalf Of Menon, Nishanth >> Sent: Thursday, September 16, 2010 10:40 PM >> To: Linus Walleij >> Cc: Kevin Hilman; linux-omap@vger.kernel.org; linux-arm- >> kernel@lists.infradead.org >> Subject: Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific >> OPPs >> >> Linus Walleij had written, on 09/16/2010 12:07 PM, the following: >> > 2010/9/16 Kevin Hilman : >> > >> >> lib/opp/* seems more appropriate to me with the header at >> >> include/linux/opp.h as Linus suggested. >> > >> > I second this. I would love to see the generic OPP stuff in >> > lib/opp/* so we put it in the right place from the beginning and >> > don't have to painfully refactor everything later (clk.h >> > especially comes to mind.) >> cool.. digging a bit deeper into lib directory, I propose the following: >> lib/opp.c >> include/linux/opp.h >> >> any soc specific data (for registration etc) -> goes to >> arch//mach-/oppdata_xyz.c or what ever they choose >> >> the intent being lib/ is no place to put mach or arch specific data >> definitions.. it is just noise.. >> >> if folks are ok with this, will post a new rev soonish.. >> > If you like may be you can take this thread over lkml just to get more > wider perspective I propose Nishanth does the slight rework to move this to lib/ and then post to l-o, l-a-k and lkml for RFC. Note that only the generic parts should be posted first, the OMAP specific usage of this can be fixed after the generic parts are accepted. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@deeprootsystems.com (Kevin Hilman) Date: Thu, 16 Sep 2010 11:01:07 -0700 Subject: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs In-Reply-To: (Santosh Shilimkar's message of "Thu, 16 Sep 2010 22:43:03 +0530") References: <1284587799-9637-1-git-send-email-khilman@deeprootsystems.com> <1284587799-9637-2-git-send-email-khilman@deeprootsystems.com> <87sk19eneu.fsf@deeprootsystems.com> <4C92386F.2070600@ti.com> <87vd65bsfs.fsf@deeprootsystems.com> <4C924F6E.6040804@ti.com> Message-ID: <87lj718t5o.fsf@deeprootsystems.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org "Shilimkar, Santosh" writes: >> -----Original Message----- >> From: linux-omap-owner at vger.kernel.org [mailto:linux-omap- >> owner at vger.kernel.org] On Behalf Of Menon, Nishanth >> Sent: Thursday, September 16, 2010 10:40 PM >> To: Linus Walleij >> Cc: Kevin Hilman; linux-omap at vger.kernel.org; linux-arm- >> kernel at lists.infradead.org >> Subject: Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific >> OPPs >> >> Linus Walleij had written, on 09/16/2010 12:07 PM, the following: >> > 2010/9/16 Kevin Hilman : >> > >> >> lib/opp/* seems more appropriate to me with the header at >> >> include/linux/opp.h as Linus suggested. >> > >> > I second this. I would love to see the generic OPP stuff in >> > lib/opp/* so we put it in the right place from the beginning and >> > don't have to painfully refactor everything later (clk.h >> > especially comes to mind.) >> cool.. digging a bit deeper into lib directory, I propose the following: >> lib/opp.c >> include/linux/opp.h >> >> any soc specific data (for registration etc) -> goes to >> arch//mach-/oppdata_xyz.c or what ever they choose >> >> the intent being lib/ is no place to put mach or arch specific data >> definitions.. it is just noise.. >> >> if folks are ok with this, will post a new rev soonish.. >> > If you like may be you can take this thread over lkml just to get more > wider perspective I propose Nishanth does the slight rework to move this to lib/ and then post to l-o, l-a-k and lkml for RFC. Note that only the generic parts should be posted first, the OMAP specific usage of this can be fixed after the generic parts are accepted. Kevin