From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 774F1C64ED6 for ; Tue, 28 Feb 2023 09:25:03 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 4BF193CBC84 for ; Tue, 28 Feb 2023 10:25:01 +0100 (CET) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [217.194.8.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id A11C43C01AA for ; Tue, 28 Feb 2023 10:24:51 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id B0A831000520 for ; Tue, 28 Feb 2023 10:24:50 +0100 (CET) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id AB8251FDC2; Tue, 28 Feb 2023 09:24:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1677576289; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cm7UKaE9CiKGTrPen+uFlwEdt/Cfi6/M/ssPWdI5a9U=; b=rsqTjFlh1CCKie5sf+GO8kN96QmTIvE54siXlkK9S9vBJ5yJo4lfhcxQJRUTMQsnfz6XvQ igjAwZiw0Kuxkx0HJHm5EYCgatni4jk1kZqrLSCJqt6mgqZ5deL06tuv7Fbd6805l4ChBX tShKMkfxykNBpSlbTpUlydkZP16HoFY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1677576289; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cm7UKaE9CiKGTrPen+uFlwEdt/Cfi6/M/ssPWdI5a9U=; b=+Oi5SpM2qYRchlGpbosHYm+NEJoTmNB4hBrCCz7aRwDdbWg02feebavuaCrHp5BWW52DRd uKVAGQMH3FV8lXCw== Received: from g78 (unknown [10.163.28.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 7E2572C141; Tue, 28 Feb 2023 09:24:49 +0000 (UTC) References: <20230119132536.23209-1-wegao@suse.com> <20230120010533.11202-1-wegao@suse.com> User-agent: mu4e 1.8.13; emacs 28.2 From: Richard Palethorpe To: Wei Gao Date: Tue, 28 Feb 2023 09:15:19 +0000 Organization: Linux Private Site In-reply-to: <20230120010533.11202-1-wegao@suse.com> Message-ID: <87mt4yuopq.fsf@suse.de> MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.102.4 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2] Move semaphore/ tests to semop/ X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rpalethorpe@suse.de Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hello, Wei Gao via ltp writes: > There is no point in having two different directories with semop() > testcaes so it would make sense to move these two tests into the > syscalls/ipc/semop/ directory as semop04 and semop05. > So we move ipc/semaphore/ tests to syscalls/ipc/semop/. > Also update runtest files accordingly. Yes, true. However these tests are using the old API. It makes sense to move them and update to the new API at the same time. Maybe they even test the same things as the other tests, so they could be deduplicated. I like breaking things into small tasks, but this is actually too small. I think it would be better to convert and move one test at a time as well (in separate commits, but in the same patch series). -- Thank you, Richard. -- Mailing list info: https://lists.linux.it/listinfo/ltp