All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org,  marcandre.lureau@redhat.com,
	 mst@redhat.com, imammedo@redhat.com,  ani@anisinha.ca,
	 eduardo@habkost.net, marcel.apfelbaum@gmail.com,
	 philmd@linaro.org,  wangyanan55@huawei.com, jiri@resnulli.us,
	 jasowang@redhat.com,  pavel.dovgaluk@ispras.ru,
	pbonzini@redhat.com,  zhanghailiang@xfusion.com,
	 dgilbert@redhat.com, michael.roth@amd.com,  kkostiuk@redhat.com
Subject: Re: [PATCH 04/12] hw/core: Improve error message when machine doesn't provide NMIs
Date: Tue, 07 Feb 2023 09:47:33 +0100	[thread overview]
Message-ID: <87mt5pc15m.fsf@secure.mitica> (raw)
In-Reply-To: <20230207075115.1525-5-armbru@redhat.com> (Markus Armbruster's message of "Tue, 7 Feb 2023 08:51:07 +0100")

Markus Armbruster <armbru@redhat.com> wrote:
> The QERR_ macros are leftovers from the days of "rich" error objects.
> We've been trying to reduce their remaining use.
>
> Get rid of a use of QERR_UNSUPPORTED, and improve the rather vague
> error message
>
>     (qemu) nmi
>     Error: this feature or command is not currently supported
>
> to
>
>     Error: machine does not provide NMIs
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

Much better error message.



  reply	other threads:[~2023-02-07  8:48 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-07  7:51 [PATCH 00/12] error: Reduce qerror.h usage a bit more Markus Armbruster
2023-02-07  7:51 ` [PATCH 01/12] error: Drop superfluous #include "qapi/qmp/qerror.h" Markus Armbruster
2023-02-07  8:45   ` Juan Quintela
2023-02-07 16:26     ` Konstantin Kostiuk
2023-02-07  7:51 ` [PATCH 02/12] dump: Improve error message when target doesn't support memory dump Markus Armbruster
2023-02-07  8:32   ` Philippe Mathieu-Daudé
2023-02-07 12:00     ` Markus Armbruster
2023-02-07  8:45   ` Juan Quintela
2023-02-07  7:51 ` [PATCH 03/12] dump: Assert cpu_get_note_size() can't fail Markus Armbruster
2023-02-07  8:46   ` Juan Quintela
2023-02-07  7:51 ` [PATCH 04/12] hw/core: Improve error message when machine doesn't provide NMIs Markus Armbruster
2023-02-07  8:47   ` Juan Quintela [this message]
2023-02-07  7:51 ` [PATCH 05/12] hw/smbios: Dumb down smbios_entry_add() stub Markus Armbruster
2023-02-07  8:50   ` Juan Quintela
2023-02-07  7:51 ` [PATCH 06/12] hw/acpi: Dumb down acpi_table_add() stub Markus Armbruster
2023-02-07  8:51   ` Juan Quintela
2023-02-07  7:51 ` [PATCH 07/12] hw/acpi: Move QMP command to hw/core/ Markus Armbruster
2023-02-07  8:52   ` Juan Quintela
2023-02-07  7:51 ` [PATCH 08/12] qga: Drop dangling reference to QERR_QGA_LOGGING_DISABLED Markus Armbruster
2023-02-07  8:53   ` Juan Quintela
2023-02-07 16:26     ` Konstantin Kostiuk
2023-02-07  7:51 ` [PATCH 09/12] replay: Simplify setting replay blockers Markus Armbruster
2023-02-07  8:38   ` Philippe Mathieu-Daudé
2023-02-07 12:50     ` Markus Armbruster
2023-02-07  7:51 ` [PATCH 10/12] hw/core: Improve the query-hotpluggable-cpus error message Markus Armbruster
2023-02-07  8:40   ` Philippe Mathieu-Daudé
2023-02-07 12:53     ` Markus Armbruster
2023-02-07  7:51 ` [PATCH 11/12] migration/colo: Improve an x-colo-lost-heartbeat " Markus Armbruster
2023-02-07  9:03   ` Juan Quintela
2023-02-07 10:10     ` Markus Armbruster
2023-02-07  7:51 ` [PATCH 12/12] rocker: Tweak stubbed out monitor commands' error messages Markus Armbruster
2023-02-07  9:04   ` Juan Quintela
2023-02-07  8:41 ` [PATCH 00/12] error: Reduce qerror.h usage a bit more Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mt5pc15m.fsf@secure.mitica \
    --to=quintela@redhat.com \
    --cc=ani@anisinha.ca \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=imammedo@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=jiri@resnulli.us \
    --cc=kkostiuk@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=michael.roth@amd.com \
    --cc=mst@redhat.com \
    --cc=pavel.dovgaluk@ispras.ru \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wangyanan55@huawei.com \
    --cc=zhanghailiang@xfusion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.