From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BE6FC4332F for ; Wed, 16 Nov 2022 17:07:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233046AbiKPRHL (ORCPT ); Wed, 16 Nov 2022 12:07:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234460AbiKPRGl (ORCPT ); Wed, 16 Nov 2022 12:06:41 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FE305EF89; Wed, 16 Nov 2022 09:05:57 -0800 (PST) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1668618356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b0nLXzHCM/9XWJ+CMFPSpqROvymes9f+yWx6tRnxa+c=; b=lb4e92ZPrWNarh8wXVyzL34Lx5FSRAuYKSVO+wWi99kVOgC6pKy9eyOEUz2LeKKVwAnU9J POoEMyE8RXbX+nLRVcwlaMMI6hXH9MaaELMsWDxe9HQfkrYC/FukDwtL/cZ3I2aWaK5m3v wfeD2W0O3ZVtfhAfkAymQaSFAXEj2FmNhKJl6EjWye4YCJ+nnWKnifI5ZF7x2Na4O8ELWQ sgZ8wVyc3DxUotRZPGm2zaeI/Eni3ScKxnrxJMCzKiNIX/gN3p/uN1SNCt9YknAmeHF4os KZ4jKed0PqMc6rVZQQAyyToJe8hXLm94RpQc+LjjxLy5L31FLb69dV8z8uttpw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1668618356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b0nLXzHCM/9XWJ+CMFPSpqROvymes9f+yWx6tRnxa+c=; b=sYbIvezOT81QU499/hP7iD6CvOFKqoHyM3Yf48D+LHOeB+ppdhzCEz71TqsqPLg1bB8qZy 0mMPMBKYHddP/QCg== To: Bjorn Helgaas Cc: LKML , x86@kernel.org, Joerg Roedel , Will Deacon , linux-pci@vger.kernel.org, Bjorn Helgaas , Lorenzo Pieralisi , Marc Zyngier , Greg Kroah-Hartman , Jason Gunthorpe , Dave Jiang , Alex Williamson , Kevin Tian , Dan Williams , Logan Gunthorpe , Ashok Raj , Jon Mason , Allen Hubbe , "Ahmed S. Darwish" , Reinette Chatre , Michael Ellerman , Christophe Leroy , linuxppc-dev@lists.ozlabs.org Subject: Re: [patch 20/39] PCI/MSI: Move pci_enable_msi() API to api.c In-Reply-To: <20221116161839.GA1115061@bhelgaas> References: <20221116161839.GA1115061@bhelgaas> Date: Wed, 16 Nov 2022 18:05:55 +0100 Message-ID: <87mt8qq170.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 16 2022 at 10:18, Bjorn Helgaas wrote: > On Fri, Nov 11, 2022 at 02:54:46PM +0100, Thomas Gleixner wrote: >> From: Ahmed S. Darwish >> >> To distangle the maze in msi.c all exported device-driver MSI APIs are now >> to be grouped in one file, api.c. >> >> Move pci_enable_msi() and make its kernel-doc comprehensive. >> >> Signed-off-by: Ahmed S. Darwish >> Signed-off-by: Thomas Gleixner > > Acked-by: Bjorn Helgaas > > Nit: suggest "disentangle" or "untangle" for "distangle" here and in > subsequent patches. My fault. I suggested the word to Ahmed well knowing that this is one of the words I never get spelled correctly :) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2B91C4332F for ; Wed, 16 Nov 2022 17:07:52 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4NC8cl17S6z3fBG for ; Thu, 17 Nov 2022 04:07:51 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=lb4e92ZP; dkim=fail reason="signature verification failed" header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=sYbIvezO; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linutronix.de (client-ip=193.142.43.55; helo=galois.linutronix.de; envelope-from=tglx@linutronix.de; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=lb4e92ZP; dkim=pass header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=sYbIvezO; dkim-atps=neutral Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4NC8ZZ74Bqz3f7B for ; Thu, 17 Nov 2022 04:05:58 +1100 (AEDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1668618356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b0nLXzHCM/9XWJ+CMFPSpqROvymes9f+yWx6tRnxa+c=; b=lb4e92ZPrWNarh8wXVyzL34Lx5FSRAuYKSVO+wWi99kVOgC6pKy9eyOEUz2LeKKVwAnU9J POoEMyE8RXbX+nLRVcwlaMMI6hXH9MaaELMsWDxe9HQfkrYC/FukDwtL/cZ3I2aWaK5m3v wfeD2W0O3ZVtfhAfkAymQaSFAXEj2FmNhKJl6EjWye4YCJ+nnWKnifI5ZF7x2Na4O8ELWQ sgZ8wVyc3DxUotRZPGm2zaeI/Eni3ScKxnrxJMCzKiNIX/gN3p/uN1SNCt9YknAmeHF4os KZ4jKed0PqMc6rVZQQAyyToJe8hXLm94RpQc+LjjxLy5L31FLb69dV8z8uttpw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1668618356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b0nLXzHCM/9XWJ+CMFPSpqROvymes9f+yWx6tRnxa+c=; b=sYbIvezOT81QU499/hP7iD6CvOFKqoHyM3Yf48D+LHOeB+ppdhzCEz71TqsqPLg1bB8qZy 0mMPMBKYHddP/QCg== To: Bjorn Helgaas Subject: Re: [patch 20/39] PCI/MSI: Move pci_enable_msi() API to api.c In-Reply-To: <20221116161839.GA1115061@bhelgaas> References: <20221116161839.GA1115061@bhelgaas> Date: Wed, 16 Nov 2022 18:05:55 +0100 Message-ID: <87mt8qq170.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pci@vger.kernel.org, Will Deacon , Lorenzo Pieralisi , Dave Jiang , Ashok Raj , Joerg Roedel , x86@kernel.org, Jason Gunthorpe , Allen Hubbe , Kevin Tian , "Ahmed S. Darwish" , Jon Mason , linuxppc-dev@lists.ozlabs.org, Alex Williamson , Bjorn Helgaas , Dan Williams , Reinette Chatre , Greg Kroah-Hartman , LKML , Marc Zyngier , Logan Gunthorpe Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Nov 16 2022 at 10:18, Bjorn Helgaas wrote: > On Fri, Nov 11, 2022 at 02:54:46PM +0100, Thomas Gleixner wrote: >> From: Ahmed S. Darwish >> >> To distangle the maze in msi.c all exported device-driver MSI APIs are now >> to be grouped in one file, api.c. >> >> Move pci_enable_msi() and make its kernel-doc comprehensive. >> >> Signed-off-by: Ahmed S. Darwish >> Signed-off-by: Thomas Gleixner > > Acked-by: Bjorn Helgaas > > Nit: suggest "disentangle" or "untangle" for "distangle" here and in > subsequent patches. My fault. I suggested the word to Ahmed well knowing that this is one of the words I never get spelled correctly :)