From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9CD1C433FE for ; Thu, 10 Nov 2022 08:03:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232638AbiKJIDK (ORCPT ); Thu, 10 Nov 2022 03:03:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232107AbiKJIDI (ORCPT ); Thu, 10 Nov 2022 03:03:08 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11D522495F; Thu, 10 Nov 2022 00:03:07 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7CA07B820E4; Thu, 10 Nov 2022 08:03:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13ED8C433C1; Thu, 10 Nov 2022 08:03:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668067384; bh=Jua4jh6tFhZdia1JqkS7s7YEZmi91PDwi5O5yBKgJ20=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PcNBx1iieOT0mYIDTRcYzfbIBkS6ty2SVjnNFgEzRzznWBg8ym5JVGFvnGaFMP5AA lDDcZeM5czZCx2pl+Qqqa+rjoexheHVFAMjvSlI3rJSxlXy/gjQmi4Hz6UoZ0SBaW+ OkqivncGRB7ndysRBFPgkELWCUq9NF+l2PUrI/7o0JbcL8GfLfepD7RacaV1MNCpS+ c+UDDatHnMeWRLa8joFikH5weLbulL7iovNDjtzqzogzlmugwuxbfmBwEK1aCaN1AL YlFcjYjN+MfEoijC1AJTmJaz+qTySIB6ks4LPToG8JooPIYP+TSv83vfVqLOFidpC9 ZjUWjTmGrnk+Q== Received: from ip-185-104-136-29.ptr.icomera.net ([185.104.136.29] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ot2Wb-00568A-Ig; Thu, 10 Nov 2022 08:03:01 +0000 Date: Thu, 10 Nov 2022 08:02:36 +0000 Message-ID: <87mt8zutib.wl-maz@kernel.org> From: Marc Zyngier To: Richard Fitzgerald Cc: , , , , , , , , , , Subject: Re: [PATCH 09/12] irqchip: cirrus: Add driver for Cirrus Logic CS48L31/32/33 codecs In-Reply-To: <20221109165331.29332-10-rf@opensource.cirrus.com> References: <20221109165331.29332-1-rf@opensource.cirrus.com> <20221109165331.29332-10-rf@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.104.136.29 X-SA-Exim-Rcpt-To: rf@opensource.cirrus.com, lee@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linus.walleij@linaro.org, broonie@kernel.org, tglx@linutronix.de, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, 09 Nov 2022 16:53:28 +0000, Richard Fitzgerald wrote: > > The Cirrus Logic CS48L31/32/33 audio codecs contain a programmable > interrupt controller with a variety of interrupt sources, including > GPIOs that can be used as interrupt inputs. > > This driver provides the handling for the interrupt controller. As the > codec is accessed via regmap, the generic regmap_irq functionality > is used to do most of the work. > I cannot spot a shred of interrupt controller code in there. This belongs IMO to the MFD code. It is also a direct copy of the existing irq-madera.c code, duplicated for no obvious reason. M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 522BAC433FE for ; Thu, 10 Nov 2022 08:04:08 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 84E501636; Thu, 10 Nov 2022 09:03:16 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 84E501636 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1668067446; bh=Jua4jh6tFhZdia1JqkS7s7YEZmi91PDwi5O5yBKgJ20=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=u40FoXg0DVVauKYESMQhCoOinJLeOv4dKN901ibFq/JHGuNU7t5euQcelAy25Y2Pl yC9w7elqiCdiiu4IdhNtj9CcajcRTRg2/3wCtx9zM4p/dpBkHSaXl4FC6WPagf6nIs YJ7m/N1n+g1rSuttTzpWyFRjKu3rID97E67ftwhc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 23EDCF80163; Thu, 10 Nov 2022 09:03:16 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 388D9F8021D; Thu, 10 Nov 2022 09:03:14 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 36CDEF80162 for ; Thu, 10 Nov 2022 09:03:07 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 36CDEF80162 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PcNBx1ii" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ABA0061DAF; Thu, 10 Nov 2022 08:03:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13ED8C433C1; Thu, 10 Nov 2022 08:03:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668067384; bh=Jua4jh6tFhZdia1JqkS7s7YEZmi91PDwi5O5yBKgJ20=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PcNBx1iieOT0mYIDTRcYzfbIBkS6ty2SVjnNFgEzRzznWBg8ym5JVGFvnGaFMP5AA lDDcZeM5czZCx2pl+Qqqa+rjoexheHVFAMjvSlI3rJSxlXy/gjQmi4Hz6UoZ0SBaW+ OkqivncGRB7ndysRBFPgkELWCUq9NF+l2PUrI/7o0JbcL8GfLfepD7RacaV1MNCpS+ c+UDDatHnMeWRLa8joFikH5weLbulL7iovNDjtzqzogzlmugwuxbfmBwEK1aCaN1AL YlFcjYjN+MfEoijC1AJTmJaz+qTySIB6ks4LPToG8JooPIYP+TSv83vfVqLOFidpC9 ZjUWjTmGrnk+Q== Received: from ip-185-104-136-29.ptr.icomera.net ([185.104.136.29] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ot2Wb-00568A-Ig; Thu, 10 Nov 2022 08:03:01 +0000 Date: Thu, 10 Nov 2022 08:02:36 +0000 Message-ID: <87mt8zutib.wl-maz@kernel.org> From: Marc Zyngier To: Richard Fitzgerald Subject: Re: [PATCH 09/12] irqchip: cirrus: Add driver for Cirrus Logic CS48L31/32/33 codecs In-Reply-To: <20221109165331.29332-10-rf@opensource.cirrus.com> References: <20221109165331.29332-1-rf@opensource.cirrus.com> <20221109165331.29332-10-rf@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.104.136.29 X-SA-Exim-Rcpt-To: rf@opensource.cirrus.com, lee@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linus.walleij@linaro.org, broonie@kernel.org, tglx@linutronix.de, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linus.walleij@linaro.org, lee@kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-gpio@vger.kernel.org, broonie@kernel.org, krzysztof.kozlowski+dt@linaro.org, tglx@linutronix.de X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 09 Nov 2022 16:53:28 +0000, Richard Fitzgerald wrote: > > The Cirrus Logic CS48L31/32/33 audio codecs contain a programmable > interrupt controller with a variety of interrupt sources, including > GPIOs that can be used as interrupt inputs. > > This driver provides the handling for the interrupt controller. As the > codec is accessed via regmap, the generic regmap_irq functionality > is used to do most of the work. > I cannot spot a shred of interrupt controller code in there. This belongs IMO to the MFD code. It is also a direct copy of the existing irq-madera.c code, duplicated for no obvious reason. M. -- Without deviation from the norm, progress is not possible.