From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 248D0C43334 for ; Wed, 13 Jul 2022 11:41:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236283AbiGMLlp (ORCPT ); Wed, 13 Jul 2022 07:41:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236087AbiGMLlo (ORCPT ); Wed, 13 Jul 2022 07:41:44 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAF31102939 for ; Wed, 13 Jul 2022 04:41:42 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9CBF520057; Wed, 13 Jul 2022 11:41:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1657712501; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ujwOx2hqDzY3hrakwFes5m5ALboygngn5vVghCM6tgM=; b=SiJzt8zqxRBO/tB1CY7IB93bVY3hgEg7/ifVEH/j4/8r3lt2l9OBqV84RkV4wFoe4e84ex k7yI+XbONhvR426u53u/8EBDg69RBFSVkbaHxwuqbf9U6JqkLxAAsu52s5+I5vo91JvfOp 1XUDUh5WLoXS1ygkfI/gUW/wtjq84EI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1657712501; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ujwOx2hqDzY3hrakwFes5m5ALboygngn5vVghCM6tgM=; b=5yiu7uSPy0mZrYv2wNJ3UtMfptv7vblJSfnBRjy2le5og3ZssQXP7Gi5P5ePwNp5r+xrvx /Xdfs4BbUrVSlpBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 74A6213754; Wed, 13 Jul 2022 11:41:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id mOqSG3WvzmIDEwAAMHmgww (envelope-from ); Wed, 13 Jul 2022 11:41:41 +0000 Date: Wed, 13 Jul 2022 13:41:41 +0200 Message-ID: <87mtddxmru.wl-tiwai@suse.de> From: Takashi Iwai To: Mark Brown Cc: Vitaly Rodionov , Jaroslav Kysela , Takashi Iwai , , , Subject: Re: [PATCH v8 00/14] ALSA: hda: cirrus: Add initial DSP support and firmware loading In-Reply-To: <87a69ii749.wl-tiwai@suse.de> References: <20220630002335.366545-1-vitalyr@opensource.cirrus.com> <87zghpxcsh.wl-tiwai@suse.de> <87a69ii749.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 09 Jul 2022 18:27:34 +0200, Takashi Iwai wrote: > > On Mon, 04 Jul 2022 14:50:06 +0200, > Takashi Iwai wrote: > > > > On Thu, 30 Jun 2022 02:23:21 +0200, > > Vitaly Rodionov wrote: > > > > > > The CS35L41 Amplifier contains a DSP, capable of running firmware. > > > The firmware can run algorithms such as Speaker Protection, to ensure > > > that playback at high gains do not harm the speakers. > > > Adding support for CS35L41 firmware into the CS35L41 HDA driver also > > > allows us to support several extra features, such as hiberation > > > and interrupts. > > > > > > The chain adds support in stages: > > > - General fixes to improve generalization and code re-use inside > > > the CS35L41 HDA driver. > > > - Add support for interrupts into the driver, which is required > > > for complete support of the firmware. > > > - Refactor ASoC CS35L41 code which deals with firmware to allow > > > for code re-use inside the CS35L41 HDA driver. > > > - Add support for loading firmware and tuning files from file system, > > > and creating alsa controls to control it. > > > - Support firmware load paths for different hardware systems. > > > - Support suspend/resume in the driver when using firmware. The firmware > > > supports hibernation, which allows the CS35L41 to drop into a low > > > power mode during suspend. > > > - Support the ability to unload firmware, swap and reload the firmware. > > > This is to allow different firmware to run during calibration. > > > > > > The intended use-case is to load the firmware once on boot, and the driver > > > autmatically tries to load the firmware after it binds to the HDA driver. > > > This behaviour can be switched off using a kconfig, if desired. > > > > > > changes since v7: > > > - Use private_data rather than private_value to save control info > > > - Clean up alsa control memory allocation/deallocation > > > - Remove unnecessary whitespace > > > - Get subsystem id from codec, rather than saving it separately > > > > > > changes since v6: > > > - Fix warning by kernel test robot > > > > > > changes since v5: > > > - Fix warning by kernel test robot > > > > > > changes since v4: > > > - Fully remove tlv remnants from control add apis > > > - Remove unnecessary debug > > > - Rename variable to be more generic > > > - Remove redundent length check from read/write control apis > > > > > > > > > - Use SNDRV_CTL_ELEM_IFACE_CARD for firmware load controls > > > - Make kcontrol add/remove synchronous > > > - Load firmware asynchronous when loading via control > > > - Used cached controls when reloading firmware; only delete > > > controls when removing the driver itself > > > > > > > > > - Improve kcontrol remove > > > - Fix control write + notify > > > - Cleanup of unnecessary code > > > - Fix race condition when loading firmware before playback > > > - Ensure errors are properly propogated > > > - Fix include for Module parameters > > > > > > Stefan Binding (13): > > > ALSA: hda: hda_cs_dsp_ctl: Add Library to support CS_DSP ALSA controls > > > ALSA: hda: hda_cs_dsp_ctl: Add apis to write the controls directly > > > ALSA: hda: cs35l41: Save codec object inside component struct > > > ALSA: hda: cs35l41: Save Subsystem ID inside CS35L41 Driver > > > ALSA: hda: cs35l41: Support reading subsystem id from ACPI > > > ALSA: hda: cs35l41: Support multiple load paths for firmware > > > ALSA: hda: cs35l41: Support Speaker ID for laptops > > > ALSA: hda: cs35l41: Support Hibernation during Suspend > > > ALSA: hda: cs35l41: Read Speaker Calibration data from UEFI variables > > > ALSA: hda: hda_cs_dsp_ctl: Add fw id strings > > > ALSA: hda: cs35l41: Add defaulted values into dsp bypass config > > > sequence > > > ALSA: hda: cs35l41: Support Firmware switching and reloading > > > ALSA: hda: cs35l41: Add module parameter to control firmware load > > > > > > Vitaly Rodionov (1): > > > ALSA: hda: cs35l41: Add initial DSP support and firmware loading > > > > Thanks, this version looks better than previous ones, and I'm fine to > > apply as is, to make things going forward. But this seems requiring > > the prerequisite in ASoC codec side. > > > > Mark, could you send a PR to merge into my tree so that I can apply > > those series? > > Mark? > > This series need the ASoC for-next change as prerequisite. Mark? It's been preventing the merge. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C33CC433EF for ; Wed, 13 Jul 2022 11:42:44 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 42E381716; Wed, 13 Jul 2022 13:41:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 42E381716 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1657712562; bh=91Y8W1iYOIcndzbyUOt8YxBPsVyYrWTcnloK8q+0zfY=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=W+JWi9E/B6+K42FvbOlqlfikShMUqWN0MPPKLJzvVoHpJYOApUknnoEUstIj23kJF NDpEc5/X+JvVY+3zy0Fqv9r/4DIwU3Y2APkc5+/j6Rvfurdb/qsMT9veKnlk0SXBJG oYeuyYmy2kzjawkUSkohc0kBnW6DfNcL9rhh1ZXs= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id BF7C8F8019B; Wed, 13 Jul 2022 13:41:51 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 85072F80249; Wed, 13 Jul 2022 13:41:50 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7E761F8012B for ; Wed, 13 Jul 2022 13:41:42 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7E761F8012B Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="SiJzt8zq"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="5yiu7uSP" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9CBF520057; Wed, 13 Jul 2022 11:41:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1657712501; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ujwOx2hqDzY3hrakwFes5m5ALboygngn5vVghCM6tgM=; b=SiJzt8zqxRBO/tB1CY7IB93bVY3hgEg7/ifVEH/j4/8r3lt2l9OBqV84RkV4wFoe4e84ex k7yI+XbONhvR426u53u/8EBDg69RBFSVkbaHxwuqbf9U6JqkLxAAsu52s5+I5vo91JvfOp 1XUDUh5WLoXS1ygkfI/gUW/wtjq84EI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1657712501; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ujwOx2hqDzY3hrakwFes5m5ALboygngn5vVghCM6tgM=; b=5yiu7uSPy0mZrYv2wNJ3UtMfptv7vblJSfnBRjy2le5og3ZssQXP7Gi5P5ePwNp5r+xrvx /Xdfs4BbUrVSlpBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 74A6213754; Wed, 13 Jul 2022 11:41:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id mOqSG3WvzmIDEwAAMHmgww (envelope-from ); Wed, 13 Jul 2022 11:41:41 +0000 Date: Wed, 13 Jul 2022 13:41:41 +0200 Message-ID: <87mtddxmru.wl-tiwai@suse.de> From: Takashi Iwai To: Mark Brown Subject: Re: [PATCH v8 00/14] ALSA: hda: cirrus: Add initial DSP support and firmware loading In-Reply-To: <87a69ii749.wl-tiwai@suse.de> References: <20220630002335.366545-1-vitalyr@opensource.cirrus.com> <87zghpxcsh.wl-tiwai@suse.de> <87a69ii749.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, Vitaly Rodionov , patches@opensource.cirrus.com, Takashi Iwai , linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sat, 09 Jul 2022 18:27:34 +0200, Takashi Iwai wrote: > > On Mon, 04 Jul 2022 14:50:06 +0200, > Takashi Iwai wrote: > > > > On Thu, 30 Jun 2022 02:23:21 +0200, > > Vitaly Rodionov wrote: > > > > > > The CS35L41 Amplifier contains a DSP, capable of running firmware. > > > The firmware can run algorithms such as Speaker Protection, to ensure > > > that playback at high gains do not harm the speakers. > > > Adding support for CS35L41 firmware into the CS35L41 HDA driver also > > > allows us to support several extra features, such as hiberation > > > and interrupts. > > > > > > The chain adds support in stages: > > > - General fixes to improve generalization and code re-use inside > > > the CS35L41 HDA driver. > > > - Add support for interrupts into the driver, which is required > > > for complete support of the firmware. > > > - Refactor ASoC CS35L41 code which deals with firmware to allow > > > for code re-use inside the CS35L41 HDA driver. > > > - Add support for loading firmware and tuning files from file system, > > > and creating alsa controls to control it. > > > - Support firmware load paths for different hardware systems. > > > - Support suspend/resume in the driver when using firmware. The firmware > > > supports hibernation, which allows the CS35L41 to drop into a low > > > power mode during suspend. > > > - Support the ability to unload firmware, swap and reload the firmware. > > > This is to allow different firmware to run during calibration. > > > > > > The intended use-case is to load the firmware once on boot, and the driver > > > autmatically tries to load the firmware after it binds to the HDA driver. > > > This behaviour can be switched off using a kconfig, if desired. > > > > > > changes since v7: > > > - Use private_data rather than private_value to save control info > > > - Clean up alsa control memory allocation/deallocation > > > - Remove unnecessary whitespace > > > - Get subsystem id from codec, rather than saving it separately > > > > > > changes since v6: > > > - Fix warning by kernel test robot > > > > > > changes since v5: > > > - Fix warning by kernel test robot > > > > > > changes since v4: > > > - Fully remove tlv remnants from control add apis > > > - Remove unnecessary debug > > > - Rename variable to be more generic > > > - Remove redundent length check from read/write control apis > > > > > > > > > - Use SNDRV_CTL_ELEM_IFACE_CARD for firmware load controls > > > - Make kcontrol add/remove synchronous > > > - Load firmware asynchronous when loading via control > > > - Used cached controls when reloading firmware; only delete > > > controls when removing the driver itself > > > > > > > > > - Improve kcontrol remove > > > - Fix control write + notify > > > - Cleanup of unnecessary code > > > - Fix race condition when loading firmware before playback > > > - Ensure errors are properly propogated > > > - Fix include for Module parameters > > > > > > Stefan Binding (13): > > > ALSA: hda: hda_cs_dsp_ctl: Add Library to support CS_DSP ALSA controls > > > ALSA: hda: hda_cs_dsp_ctl: Add apis to write the controls directly > > > ALSA: hda: cs35l41: Save codec object inside component struct > > > ALSA: hda: cs35l41: Save Subsystem ID inside CS35L41 Driver > > > ALSA: hda: cs35l41: Support reading subsystem id from ACPI > > > ALSA: hda: cs35l41: Support multiple load paths for firmware > > > ALSA: hda: cs35l41: Support Speaker ID for laptops > > > ALSA: hda: cs35l41: Support Hibernation during Suspend > > > ALSA: hda: cs35l41: Read Speaker Calibration data from UEFI variables > > > ALSA: hda: hda_cs_dsp_ctl: Add fw id strings > > > ALSA: hda: cs35l41: Add defaulted values into dsp bypass config > > > sequence > > > ALSA: hda: cs35l41: Support Firmware switching and reloading > > > ALSA: hda: cs35l41: Add module parameter to control firmware load > > > > > > Vitaly Rodionov (1): > > > ALSA: hda: cs35l41: Add initial DSP support and firmware loading > > > > Thanks, this version looks better than previous ones, and I'm fine to > > apply as is, to make things going forward. But this seems requiring > > the prerequisite in ASoC codec side. > > > > Mark, could you send a PR to merge into my tree so that I can apply > > those series? > > Mark? > > This series need the ASoC for-next change as prerequisite. Mark? It's been preventing the merge. Takashi