From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id B13A410E253 for ; Tue, 8 Mar 2022 03:29:17 +0000 (UTC) Date: Mon, 07 Mar 2022 19:18:19 -0800 Message-ID: <87mti1xhc4.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Zbigniew =?ISO-8859-2?Q?Kempczy=F1ski?= In-Reply-To: References: <20220303140636.26652-1-anshuman.gupta@intel.com> <20220303140636.26652-2-anshuman.gupta@intel.com> <87o82kzzal.wl-ashutosh.dixit@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable Subject: Re: [igt-dev] [PATCH i-g-t 1/2] i915/gem_eio: Exercise object creation while wedged List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, Chris Wilson , chris.p.wilson@intel.com Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Mon, 07 Mar 2022 00:02:00 -0800, Zbigniew Kempczy=F1ski wrote: > > I got no objection. It covers single case (iterating over regions) but > this is most common case. BTW self-freeing iterator is smartly coded. One > question is - why this is not a part of intel_memory_region.[ch]. Do we > need to introduce another file if this is related to memory regioning? Agreed, can we please add the functions to intel_memory_region.[ch] itself and repost? Thanks.