From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEBBEC433F5 for ; Tue, 2 Nov 2021 07:40:22 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6109C60E9B for ; Tue, 2 Nov 2021 07:40:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6109C60E9B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 37AD760682; Tue, 2 Nov 2021 07:40:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rLRsdBgGujnN; Tue, 2 Nov 2021 07:40:21 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id CB76D605D5; Tue, 2 Nov 2021 07:40:20 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id B5457C0012; Tue, 2 Nov 2021 07:40:20 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2AC42C000E for ; Tue, 2 Nov 2021 07:40:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 0C60F402B5 for ; Tue, 2 Nov 2021 07:40:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 69tBx-rbEnDz for ; Tue, 2 Nov 2021 07:40:18 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id 3C097402AF for ; Tue, 2 Nov 2021 07:40:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635838817; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rPu+TEWex7DM2XBPyMWNsPrFrpctl7ejYlHuF04HTQA=; b=Hh0oMvDXN2YmljNDLMOBzE4IQSIQsYBNEYErTrxoa0NvN1dCfOsxT1N61y5vMsKdLdg9eJ zED0wPN9UySeuebechWMdFWqmfAtI7yEedPVuYPEhvBvvuWw8PfmA8fWwhYTYl8hcwJshV R6eSROGOcZ509czgQAxAS1doAv8ZRaM= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-595-YoK2mwF1Nh-E4U6F8rIl1Q-1; Tue, 02 Nov 2021 03:40:14 -0400 X-MC-Unique: YoK2mwF1Nh-E4U6F8rIl1Q-1 Received: by mail-wm1-f69.google.com with SMTP id b133-20020a1c808b000000b0032cdd691994so719228wmd.1 for ; Tue, 02 Nov 2021 00:40:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:reply-to:date:message-id:mime-version :content-transfer-encoding; bh=rPu+TEWex7DM2XBPyMWNsPrFrpctl7ejYlHuF04HTQA=; b=vsyyYUdw30+EJw9++g7nSZ4BIlrnllzK4ePy5FhyttFZV4JPCdpMLgc5uhqWyM43+f 5A37stkdiTczWjH1UmfbDMBk46Gjw5KcVPyM5sYmT01urZq3Z+eGF7GKXCzFwyqInhx+ Y4yPYMs74Xds1JBmaLYVS5FaT/ro8gbHQW6wow+1QyCYTZPdvzxp3X+g91eWScfmbvPf OgPXVCwQ84Vo9ge1YVrjpHEig+P5Gsmg7QT7uJvhEAq1Fvj3p6hf6w9Kjvk4LPjR9AVS 5glxXwqW14T1Ca+d4nVspACePl794cXDmVWTwM//67M0gDwiRlrqK7O5mJx+LVnWFn2r hgjQ== X-Gm-Message-State: AOAM530TnN6TsM9N1L8MfpQXKvhMlq0pGhp3pvloir7xKla2cCsMLQCl ABrwKmF831lERCaEEba75KchcCj5KUxuizROAcdoiCcPU5gV8lUmPa7Z1EStfm4KUNMOl++tW4Q 69dIjExwsAreLcUBQfFelSpR7ZbzXFN8TAAIzD5hJGw== X-Received: by 2002:a7b:c303:: with SMTP id k3mr5030192wmj.44.1635838813083; Tue, 02 Nov 2021 00:40:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxDXjZ2/S+Zu4EmMWCEIeewzQXHCc0CYy7LGlLuQHKmQa056kHgEW9fPc0Xyhggtn8VOI4Tew== X-Received: by 2002:a7b:c303:: with SMTP id k3mr5030164wmj.44.1635838812943; Tue, 02 Nov 2021 00:40:12 -0700 (PDT) Received: from localhost ([188.26.219.88]) by smtp.gmail.com with ESMTPSA id u16sm1547759wmc.21.2021.11.02.00.40.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 00:40:12 -0700 (PDT) From: Juan Quintela To: Eugenio =?utf-8?Q?P=C3=A9rez?= Subject: Re: [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq In-Reply-To: <20211029183525.1776416-3-eperezma@redhat.com> ("Eugenio =?utf-8?Q?P=C3=A9rez=22's?= message of "Fri, 29 Oct 2021 20:35:01 +0200") References: <20211029183525.1776416-1-eperezma@redhat.com> <20211029183525.1776416-3-eperezma@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Date: Tue, 02 Nov 2021 08:40:11 +0100 Message-ID: <87mtmnngys.fsf@secure.mitica> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=quintela@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Cc: Laurent Vivier , Eduardo Habkost , "Michael S. Tsirkin" , Richard Henderson , qemu-devel@nongnu.org, Markus Armbruster , Stefan Hajnoczi , Xiao W Wang , Harpreet Singh Anand , Eli Cohen , Paolo Bonzini , Eric Blake , virtualization@lists.linux-foundation.org, Parav Pandit X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" RXVnZW5pbyBQw6lyZXogPGVwZXJlem1hQHJlZGhhdC5jb20+IHdyb3RlOgo+IFRoZSAtMSBhc3N1 bWVzIHRoYXQgYWxsIGRldmljZXMgd2l0aCBubyBjdnEgaGF2ZSBhbiBzcGFyZSB2cSBhbGxvY2F0 ZWQKPiBmb3IgdGhlbSwgYnV0IHdpdGggbm8gb2ZmZXIgb2YgVklSVElPX05FVF9GX0NUUkxfVlEu IFRoaXMgbWF5IG5vdCBiZSB0aGUKPiBjYXNlLCBhbmQgdGhlIGRldmljZSBtYXkgaGF2ZSBhIHBh aXIgbnVtYmVyIG9mIHF1ZXVlcy4KPgo+IFRvIGZpeCB0aGlzLCBqdXN0IHJlc29ydCB0byB0aGUg bG93ZXIgZXZlbiBudW1iZXIgb2YgcXVldWVzLgo+Cj4gRml4ZXM6IDA0OWViMTViNWZjOSAoInZo b3N0OiByZWNvcmQgdGhlIGxhc3QgdmlydHF1ZXVlIGluZGV4IGZvciB0aGUKPiB2aXJ0aW8gZGV2 aWNlIikKPiBTaWduZWQtb2ZmLWJ5OiBFdWdlbmlvIFDDqXJleiA8ZXBlcmV6bWFAcmVkaGF0LmNv bT4KClJldmlld2VkLWJ5OiBKdWFuIFF1aW50ZWxhIDxxdWludGVsYUByZWRoYXQuY29tPgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KVmlydHVhbGl6YXRp b24gbWFpbGluZyBsaXN0ClZpcnR1YWxpemF0aW9uQGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3Jn Cmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3ZpcnR1 YWxpemF0aW9u From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7742C433EF for ; Tue, 2 Nov 2021 07:41:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADDD360EB9 for ; Tue, 2 Nov 2021 07:41:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org ADDD360EB9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:45720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhoQ8-0003zv-Co for qemu-devel@archiver.kernel.org; Tue, 02 Nov 2021 03:41:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44640) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhoP4-0002Z7-8R for qemu-devel@nongnu.org; Tue, 02 Nov 2021 03:40:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44759) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhoP2-0000wy-3I for qemu-devel@nongnu.org; Tue, 02 Nov 2021 03:40:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635838815; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rPu+TEWex7DM2XBPyMWNsPrFrpctl7ejYlHuF04HTQA=; b=L2vKuj03Z7X7FZRQ5vZfDV7Ap3r68moOKooTjNyV0d3dPAjnl2Vgou/7Fhjr77YCkgbUhz oIfbmvtSqjYjIFFXBD9sbpfAEMl9qlusEMRpaPuaWN2LmGnlwJr/vCClnsyxDWOo6j1LoE csFUXXyEkhXWfT80FcfVaSfOzihXg50= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-530-kd0HupqvPeOyq_r664Zg5A-1; Tue, 02 Nov 2021 03:40:14 -0400 X-MC-Unique: kd0HupqvPeOyq_r664Zg5A-1 Received: by mail-wm1-f71.google.com with SMTP id 144-20020a1c0496000000b003305ac0e03aso704968wme.8 for ; Tue, 02 Nov 2021 00:40:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:reply-to:date:message-id:mime-version :content-transfer-encoding; bh=rPu+TEWex7DM2XBPyMWNsPrFrpctl7ejYlHuF04HTQA=; b=3w3QLkQkogQhwGOBjgq+ed3NJ8M37DHPFrhNbzfNzZ/UvPHURzLkmoTO2vCldPQUZT 7pfHIu5XWlGgfYmsD/IWvGgsKEBbyGCOOl6Vf29TXlT+3NK4Ee5fk0HodZUqAb7NNhX6 7RDo2rZN6F3f3xz/DkurzPHPkOilxIi8iZalSxHkiw6uNWP0VPHBBWatQbMxnmeK4glM jOA8R5ZnwX5ovdt+cqRSO1c9hkkcbgZLl14r4eyiVT8BsuX925ZU6Lr1DZqFE/MtxT8q 4wcLDNarW5QiRHjS2xfInqFDRgFCwHeTl/15KxZ3Qg9Gpd9TFPfLG72Z0ojOu4Z+Lfw7 KiYA== X-Gm-Message-State: AOAM5304Ej5sH11GVig4HtHoBH3DPuhmqQ+bKNSMNUZIdxKKiq+zm76H 9vTL5uobo4hWbTPw19SdrO5pZMeGFAPreLYt4xxZdLohbvoXfKmree8s6FZRIgpq3ecBPctfmfA /8KyhZ8h4MOAMSzU= X-Received: by 2002:a7b:c303:: with SMTP id k3mr5030188wmj.44.1635838813083; Tue, 02 Nov 2021 00:40:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxDXjZ2/S+Zu4EmMWCEIeewzQXHCc0CYy7LGlLuQHKmQa056kHgEW9fPc0Xyhggtn8VOI4Tew== X-Received: by 2002:a7b:c303:: with SMTP id k3mr5030164wmj.44.1635838812943; Tue, 02 Nov 2021 00:40:12 -0700 (PDT) Received: from localhost ([188.26.219.88]) by smtp.gmail.com with ESMTPSA id u16sm1547759wmc.21.2021.11.02.00.40.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 00:40:12 -0700 (PDT) From: Juan Quintela To: Eugenio =?utf-8?Q?P=C3=A9rez?= Subject: Re: [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq In-Reply-To: <20211029183525.1776416-3-eperezma@redhat.com> ("Eugenio =?utf-8?Q?P=C3=A9rez=22's?= message of "Fri, 29 Oct 2021 20:35:01 +0200") References: <20211029183525.1776416-1-eperezma@redhat.com> <20211029183525.1776416-3-eperezma@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Date: Tue, 02 Nov 2021 08:40:11 +0100 Message-ID: <87mtmnngys.fsf@secure.mitica> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=quintela@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.133.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.734, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Cc: Laurent Vivier , Eduardo Habkost , "Michael S. Tsirkin" , Jason Wang , Richard Henderson , qemu-devel@nongnu.org, Peter Xu , Markus Armbruster , Stefan Hajnoczi , Xiao W Wang , Harpreet Singh Anand , Eli Cohen , Paolo Bonzini , Stefano Garzarella , Eric Blake , virtualization@lists.linux-foundation.org, Parav Pandit Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Eugenio P=C3=A9rez wrote: > The -1 assumes that all devices with no cvq have an spare vq allocated > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This may not be the > case, and the device may have a pair number of queues. > > To fix this, just resort to the lower even number of queues. > > Fixes: 049eb15b5fc9 ("vhost: record the last virtqueue index for the > virtio device") > Signed-off-by: Eugenio P=C3=A9rez Reviewed-by: Juan Quintela