From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Palethorpe Date: Tue, 24 Aug 2021 13:46:25 +0100 Subject: [LTP] [PATCH 1/3] tst_test_macros: Fix TST_EXP_*() default message In-Reply-To: References: <20210823150520.25614-1-chrubis@suse.cz> <20210823150520.25614-2-chrubis@suse.cz> Message-ID: <87mtp7ko2m.fsf@suse.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hello, Li Wang writes: > On Tue, Aug 24, 2021 at 4:48 PM Cyril Hrubis wrote: > >> Hi! >> > Patchset looks good from the code layer though it is a bit complicate >> > in 2/3 stringify handling, but that should be acceptable. >> > >> > My only hesitating is about ##__VA_ARGS__, because it says that is still >> > as GNU's extension but have not got into standard C. >> >> Note that we have been using it in the header from the start. There were >> just a few places where it was missing, mostly in the variants that have >> been added later. >> > > Ah great, I was neglect that point. Hence it should be safe enough. > > -- > Regards, > Li Wang There is also __VA_OPT__(,) which can't be confused with concatenation. I'm not sure we should use it thought, it seems like it was only recently added to other compilers. Still might be a good idea to link to the following page somewhere: https://gcc.gnu.org/onlinedocs/cpp/Variadic-Macros.html#Variadic-Macros LGTM otherwise! -- Thank you, Richard.