[Buildroot] [PATCH 1/1] package/fluxbox: fix build with gcc 11

[Buildroot] [PATCH 1/1] package/fluxbox: fix build with gcc 11

[Fabrice Fontaine]

Fix the following build failure with gcc 11:

util/fluxbox-remote.cc: In function 'int main(int, char**)':
util/fluxbox-remote.cc:76:32: error: ordered comparison of pointer with integer zero ('unsigned char*' and 'int')
   76 |             && text_prop.value > 0
      |                ~~~~~~~~~~~~~~~~^~~

Fixes:
 - http://autobuild.buildroot.org/results/6e718bb662aa4961ea264eb81e4b7e7b20485e30

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/fluxbox/0001-fixes-bug-1138.patch | 25 +++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 package/fluxbox/0001-fixes-bug-1138.patch

diff --git a/package/fluxbox/0001-fixes-bug-1138.patch b/package/fluxbox/0001-fixes-bug-1138.patch
new file mode 100644
index 0000000000..9c02e93350
--- /dev/null
+++ b/package/fluxbox/0001-fixes-bug-1138.patch
@@ -0,0 +1,25 @@
+From 22866c4d30f5b289c429c5ca88d800200db4fc4f Mon Sep 17 00:00:00 2001
+From: John Sennesael <john@aminking.com>
+Date: Mon, 2 Nov 2015 15:14:32 -0600
+Subject: [PATCH] fixes bug #1138
+
+[Retrieved from:
+https://github.com/fluxbox/fluxbox/commit/22866c4d30f5b289c429c5ca88d800200db4fc4f]
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+---
+ util/fluxbox-remote.cc | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/util/fluxbox-remote.cc b/util/fluxbox-remote.cc
+index 59852e6a..504015b5 100644
+--- a/util/fluxbox-remote.cc
++++ b/util/fluxbox-remote.cc
+@@ -73,7 +73,7 @@ int main(int argc, char **argv) {
+     if (strcmp(cmd, "result") == 0) {
+         XTextProperty text_prop;
+         if (XGetTextProperty(disp, root, &text_prop, atom_result) != 0
+-            && text_prop.value > 0
++            && text_prop.value != 0
+             && text_prop.nitems > 0) {
+ 
+             printf("%s", text_prop.value);
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/fluxbox: fix build with gcc 11

[Arnout Vandecappelle]

On 02/08/2021 00:35, Fabrice Fontaine wrote:
> Fix the following build failure with gcc 11:
> 
> util/fluxbox-remote.cc: In function 'int main(int, char**)':
> util/fluxbox-remote.cc:76:32: error: ordered comparison of pointer with integer zero ('unsigned char*' and 'int')
>    76 |             && text_prop.value > 0
>       |                ~~~~~~~~~~~~~~~~^~~
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/6e718bb662aa4961ea264eb81e4b7e7b20485e30
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

 Applied to master, thanks.

 Regards,
 Arnout

> ---
>  package/fluxbox/0001-fixes-bug-1138.patch | 25 +++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>  create mode 100644 package/fluxbox/0001-fixes-bug-1138.patch
> 
> diff --git a/package/fluxbox/0001-fixes-bug-1138.patch b/package/fluxbox/0001-fixes-bug-1138.patch
> new file mode 100644
> index 0000000000..9c02e93350
> --- /dev/null
> +++ b/package/fluxbox/0001-fixes-bug-1138.patch
> @@ -0,0 +1,25 @@
> +From 22866c4d30f5b289c429c5ca88d800200db4fc4f Mon Sep 17 00:00:00 2001
> +From: John Sennesael <john@aminking.com>
> +Date: Mon, 2 Nov 2015 15:14:32 -0600
> +Subject: [PATCH] fixes bug #1138
> +
> +[Retrieved from:
> +https://github.com/fluxbox/fluxbox/commit/22866c4d30f5b289c429c5ca88d800200db4fc4f]
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +---
> + util/fluxbox-remote.cc | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/util/fluxbox-remote.cc b/util/fluxbox-remote.cc
> +index 59852e6a..504015b5 100644
> +--- a/util/fluxbox-remote.cc
> ++++ b/util/fluxbox-remote.cc
> +@@ -73,7 +73,7 @@ int main(int argc, char **argv) {
> +     if (strcmp(cmd, "result") == 0) {
> +         XTextProperty text_prop;
> +         if (XGetTextProperty(disp, root, &text_prop, atom_result) != 0
> +-            && text_prop.value > 0
> ++            && text_prop.value != 0
> +             && text_prop.nitems > 0) {
> + 
> +             printf("%s", text_prop.value);
> 
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/fluxbox: fix build with gcc 11

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Fix the following build failure with gcc 11:
 > util/fluxbox-remote.cc: In function 'int main(int, char**)':
 > util/fluxbox-remote.cc:76:32: error: ordered comparison of pointer with integer zero ('unsigned char*' and 'int')
 >    76 |             && text_prop.value > 0
 >       |                ~~~~~~~~~~~~~~~~^~~

 > Fixes:
 >  - http://autobuild.buildroot.org/results/6e718bb662aa4961ea264eb81e4b7e7b20485e30

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2021.02.x and 2021.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot