From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5810165316602251738==" MIME-Version: 1.0 From: Toke Høiland-Jørgensen To: kbuild-all@lists.01.org Subject: Re: [bpf-next:master 15/30] kernel/bpf/devmap.c:1030:40: sparse: sparse: cast removes address space '__rcu' of expression Date: Tue, 29 Jun 2021 00:42:52 +0200 Message-ID: <87mtr9k3v7.fsf@toke.dk> In-Reply-To: <20210628155329.GF4397@paulmck-ThinkPad-P17-Gen-1> List-Id: --===============5810165316602251738== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable "Paul E. McKenney" writes: > On Sat, Jun 26, 2021 at 12:00:55PM +0200, Toke H=C3=B8iland-J=C3=B8rgense= n wrote: >> +Paul - any idea why unrcu_pointer() isn't working here? > > Hello, Toke! > > My distro version of sparse core-dumped before getting that far along. > > I cloned and built the latest version, and got only the following errors > from kernel/bpf/devmap.c: > > ------------------------------------------------------------------------ > > CHECK scripts/mod/empty.c > CALL scripts/checksyscalls.sh > CALL scripts/atomic/check-atomics.sh > DESCEND objtool > CC kernel/bpf/devmap.o > CHECK kernel/bpf/devmap.c > kernel/bpf/devmap.c:561:29: warning: incorrect type in assignment (differ= ent address spaces) > kernel/bpf/devmap.c:561:29: expected struct bpf_dtab_netdev *dst > kernel/bpf/devmap.c:561:29: got struct bpf_dtab_netdev [noderef] __rcu= * > kernel/bpf/devmap.c:657:29: warning: incorrect type in assignment (differ= ent address spaces) > kernel/bpf/devmap.c:657:29: expected struct bpf_dtab_netdev *dst > kernel/bpf/devmap.c:657:29: got struct bpf_dtab_netdev [noderef] __rcu= * Hmm, but those shouldn't be there either. Seems I missed those when rebasing, will send a follow-up patch... -Toke --===============5810165316602251738==--