From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id A65866E057 for ; Fri, 18 Jun 2021 01:16:21 +0000 (UTC) Date: Thu, 17 Jun 2021 18:16:19 -0700 Message-ID: <87mtrodlb0.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <20210617191516.577394-6-jason@jlekstrand.net> References: <20210617191256.577244-1-jason@jlekstrand.net> <20210617191516.577394-6-jason@jlekstrand.net> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Subject: Re: [igt-dev] [PATCH i-g-t 55/79] lib/i915/submission: Rework gem_test_all_engines to use intel_ctx_t List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Jason Ekstrand Cc: igt-dev@lists.freedesktop.org List-ID: On Thu, 17 Jun 2021 12:14:52 -0700, Jason Ekstrand wrote: > > This function used to be called gem_test_engine but it's only ever used > to test all the engines in the GPU so we rename it for the one thing > it's used for. We also convert to intel_ctx_t. It now creates a new > context with all physical engines and iterates over all the engines in > it. Please add your SOB here. > --- > lib/i915/gem_submission.c | 19 ++++++++----------- > lib/i915/gem_submission.h | 2 +- > tests/i915/gem_eio.c | 2 +- > tests/i915/i915_pm_rpm.c | 2 +- > 4 files changed, 11 insertions(+), 14 deletions(-) > > diff --git a/lib/i915/gem_submission.c b/lib/i915/gem_submission.c > index 7c305d6d6..bec952493 100644 > --- a/lib/i915/gem_submission.c > +++ b/lib/i915/gem_submission.c > @@ -177,20 +177,23 @@ static bool is_wedged(int i915) > } > > /** > - * gem_test_engine: > + * gem_test_all_engines: > * @i915: open i915 drm file descriptor > * @engine: the engine (I915_EXEC_RING id) to exercise Delete @engine in the docs too. > * > * Execute a nop batch on the engine specified, or ALL_ENGINES for all, > * and check it executes. > */ > -void gem_test_engine(int i915, unsigned int engine) > +void gem_test_all_engines(int i915) With this this is: Reviewed-by: Ashutosh Dixit _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev