All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@kernel.org>
To: Peter Chen <hzpeterchen@gmail.com>, Peter Chen <peter.chen@nxp.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"pawell@cadence.com" <pawell@cadence.com>,
	"rogerq@ti.com" <rogerq@ti.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	Jun Li <jun.li@nxp.com>
Subject: Re: [PATCH v2 1/8] usb: cdns3: gadget: using correct sg operations
Date: Tue, 29 Sep 2020 09:29:36 +0300	[thread overview]
Message-ID: <87mu199ju7.fsf@kernel.org> (raw)
In-Reply-To: <CAL411-oSXmabZ06TB4sZNhbbPsk3fz6St=QRDzDpc2T=Hg3dfw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2148 bytes --]


Hi,

Peter Chen <hzpeterchen@gmail.com> writes:
>> > > It needs to use request->num_mapped_sgs to indicate mapped sg number,
>> > > the request->num_sgs is the sg number before the mapping. These two
>> > > entries have different values for the platforms which iommu or swiotlb
>> > > is used. Besides, it needs to use correct sg APIs for mapped sg list
>> > > for TRB assignment.
>> > >
>> > > Signed-off-by: Peter Chen <peter.chen@nxp.com>
>> >
>> > fails to apply to my testing/next
>> >
>> > checking file drivers/usb/cdns3/gadget.c Hunk #1 succeeded at 1099 (offset 1
>> > line).
>> > Hunk #2 succeeded at 1165 (offset 1 line).
>> > Hunk #3 FAILED at 1176.
>> > Hunk #4 succeeded at 1221 with fuzz 2 (offset 1 line).
>> > 1 out of 4 hunks FAILED
>> >
>>
>> It could work now, I think the possible reason is you have already applied other cdns3 patches during
>> these two hours. My git log likes below:
>>
>> ca71afbe0c52 (HEAD -> felipe_testing_next) usb: cdns3: gadget: enlarge the TRB ring length
>> 50599e28f626 usb: cdns3: gadget: sg_support is only for DEV_VER_V2 or above
>> ed1e5b0fe5b2 usb: cdns3: gadget: need to handle sg case for workaround 2 case
>> 95c952507262 usb: cdns3: gadget: handle sg list use case at completion correctly
>> 9d45b67cf0c3 usb: cdns3: gadget: add CHAIN and ISP bit for sg list use case
>> 28e5fd2c3fae usb: cdns3: gadget: calculate TDL correctly
>> f57692f1a9a4 usb: cdns3: gadget: improve the dump TRB operation at cdns3_ep_run_transfer
>> 5f94832916b5 usb: cdns3: gadget: using correct sg operations
>> bed7c9e9a5aa (felipe/testing/next) usb: dwc3: gadget: Rename misleading function names
>> 3d7ce113c2d0 usb: dwc3: gadget: Refactor preparing last TRBs
>> 43365b1e90af usb: dwc3: gadget: Set IOC if not enough for extra TRBs
>> ea52ca3fdefb usb: dwc3: gadget: Check for number of TRBs prepared
>> e6ccecf58b1b usb: dwc3: gadget: Return the number of prepared TRBs
>>
>> Thanks,
>> Peter
>
> Hi Felipe,
>
> I have still not seen these patches on your tree, would you please
> help to queue them for v5.10-rc1?

Should be in testing/next now

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]

  reply	other threads:[~2020-09-29  6:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10  9:11 [PATCH v2 0/8] usb: cdns3: improve the sg use case Peter Chen
2020-09-10  9:11 ` [PATCH v2 1/8] usb: cdns3: gadget: using correct sg operations Peter Chen
2020-09-24  7:27   ` Felipe Balbi
2020-09-24  9:33     ` Peter Chen
2020-09-29  3:40       ` Peter Chen
2020-09-29  6:29         ` Felipe Balbi [this message]
2020-09-10  9:11 ` [PATCH v2 2/8] usb: cdns3: gadget: improve the dump TRB operation at cdns3_ep_run_transfer Peter Chen
2020-09-10  9:11 ` [PATCH v2 3/8] usb: cdns3: gadget: calculate TDL correctly Peter Chen
2020-09-10  9:11 ` [PATCH v2 4/8] usb: cdns3: gadget: add CHAIN and ISP bit for sg list use case Peter Chen
2020-09-10  9:11 ` [PATCH v2 5/8] usb: cdns3: gadget: handle sg list use case at completion correctly Peter Chen
2020-09-10  9:11 ` [PATCH v2 6/8] usb: cdns3: gadget: need to handle sg case for workaround 2 case Peter Chen
2020-09-10  9:11 ` [PATCH v2 7/8] usb: cdns3: gadget: sg_support is only for DEV_VER_V2 or above Peter Chen
2020-09-10  9:11 ` [PATCH v2 8/8] usb: cdns3: gadget: enlarge the TRB ring length Peter Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mu199ju7.fsf@kernel.org \
    --to=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hzpeterchen@gmail.com \
    --cc=jun.li@nxp.com \
    --cc=linux-imx@nxp.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=pawell@cadence.com \
    --cc=peter.chen@nxp.com \
    --cc=rogerq@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.