From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADD4CC433E2 for ; Thu, 17 Sep 2020 14:24:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E72C2075B for ; Thu, 17 Sep 2020 14:24:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dtm32XLK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E72C2075B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIuq0-00083b-7r for qemu-devel@archiver.kernel.org; Thu, 17 Sep 2020 10:24:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41772) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIujW-0006TT-RS for qemu-devel@nongnu.org; Thu, 17 Sep 2020 10:17:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:59557) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kIujU-0002is-W5 for qemu-devel@nongnu.org; Thu, 17 Sep 2020 10:17:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600352275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=24jWfzjlkhKIxJSSL2cfwfuNqp054IGNzwVqyyudGDU=; b=dtm32XLKjJ25IuMjyDjFafsLsa1RGQF6a61yY6bta6E8gOL+100ymZTPDTMRN9De/13qz8 V6+LlNcL9MTXzHkpOP3Ujv4bee+CGXaqcNHa/Fox3Dks8JJu2OIdX5OGcS+QSFjrX+De54 ivJnAyL6fKvnhILx/tIgbvyik/FeHbU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-90-uv6sBA1LPgKMCWz0VKr2vA-1; Thu, 17 Sep 2020 10:17:53 -0400 X-MC-Unique: uv6sBA1LPgKMCWz0VKr2vA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DDBFF1074643; Thu, 17 Sep 2020 14:17:52 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-114-66.ams2.redhat.com [10.36.114.66]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AB5CC19D6C; Thu, 17 Sep 2020 14:17:52 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 5E4A8113864A; Thu, 17 Sep 2020 16:17:51 +0200 (CEST) From: Markus Armbruster To: John Snow Subject: Re: [PATCH 11/37] qapi/common.py: Replace one-letter 'c' variable References: <20200915224027.2529813-1-jsnow@redhat.com> <20200915224027.2529813-12-jsnow@redhat.com> Date: Thu, 17 Sep 2020 16:17:51 +0200 In-Reply-To: <20200915224027.2529813-12-jsnow@redhat.com> (John Snow's message of "Tue, 15 Sep 2020 18:40:01 -0400") Message-ID: <87mu1opjw0.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=63.128.21.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/16 20:51:18 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.997, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Cleber Rosa , Alex =?utf-8?Q?Benn=C3=A9e?= , qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" John Snow writes: > Signed-off-by: John Snow > --- > scripts/qapi/common.py | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py > index c665e67495..4c079755d3 100644 > --- a/scripts/qapi/common.py > +++ b/scripts/qapi/common.py > @@ -30,14 +30,14 @@ def camel_to_upper(value): > new_name = '' > length = len(c_fun_str) > for i in range(length): > - c = c_fun_str[i] > - # When c is upper and no '_' appears before, do more checks > - if c.isupper() and (i > 0) and c_fun_str[i - 1] != '_': > + char = c_fun_str[i] > + # When char is upper and no '_' appears before, do more checks Good opportunity to tweak the language: "When char is upper case". > + if char.isupper() and (i > 0) and c_fun_str[i - 1] != '_': > if i < length - 1 and c_fun_str[i + 1].islower(): > new_name += '_' > elif c_fun_str[i - 1].isdigit(): > new_name += '_' > - new_name += c > + new_name += char > return new_name.lstrip('_').upper()