From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D41FEC433E3 for ; Mon, 20 Jul 2020 15:25:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F5BC20709 for ; Mon, 20 Jul 2020 15:25:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="N/grj4Ge" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F5BC20709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxXfV-0007qp-Sn for qemu-devel@archiver.kernel.org; Mon, 20 Jul 2020 11:25:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxXen-0007Ji-JS for qemu-devel@nongnu.org; Mon, 20 Jul 2020 11:24:45 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:57501 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jxXek-0004zn-TY for qemu-devel@nongnu.org; Mon, 20 Jul 2020 11:24:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595258680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mjUkemNZt8Ayf3GGfnJ/0jNl6f4HscBFc7YK3mPnJ+I=; b=N/grj4GeYDMQ1iAYODt++YuwJP7zM163+Vu0zyyZ/gRlsMLN0x8W+ryEeIHneSix6dicdV L5l2kZ7Ywsbb8NkGlHuuZ+e2IsYST3vkDSk1+8HQl8/ifIvfXZBkJQ30mXxDCl8RZhzssb PYd9z5E3vIltpuHPW2VCKdpJAeQJPr0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-418-s_RD4tc2MySB0kdgmKweOg-1; Mon, 20 Jul 2020 11:24:38 -0400 X-MC-Unique: s_RD4tc2MySB0kdgmKweOg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 71B111080; Mon, 20 Jul 2020 15:24:37 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-143.ams2.redhat.com [10.36.112.143]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D1ED960E3E; Mon, 20 Jul 2020 15:24:36 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 15C771141C54; Mon, 20 Jul 2020 17:24:35 +0200 (CEST) From: Markus Armbruster To: Greg Kurz Subject: Re: [PATCH v4 for-5.2 1/2] spapr: Use error_append_hint() in spapr_caps.c References: <159491945918.188975.4358645698778061430.stgit@bahia.lan> <159491947184.188975.5055299566400098290.stgit@bahia.lan> Date: Mon, 20 Jul 2020 17:24:35 +0200 In-Reply-To: <159491947184.188975.5055299566400098290.stgit@bahia.lan> (Greg Kurz's message of "Thu, 16 Jul 2020 19:11:11 +0200") Message-ID: <87mu3uciq4.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=205.139.110.61; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/20 02:16:39 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Vladimir Sementsov-Ogievskiy , qemu-ppc@nongnu.org, Laurent Vivier , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Greg Kurz writes: > We have a dedicated error API for hints. Use it instead of embedding > the hint in the error message, as recommanded in the "qapi/error.h" > header file. > > Since spapr_caps_apply() passes &error_fatal, all functions must > also call the ERRP_GUARD() macro for error_append_hint() to be > functional. This isn't a request for change in this patch, just an attempt to squash possible misunderstandings. It's true that error_append_hint() without ERRP_GUARD() works as long as the caller doesn't pass certain errp arguments. But the callee should work for all possible @errp arguments, not just the ones that get passed today. That's why error.h wants you to guard *all* uses of error_append_hint(errp): * = Why, when and how to use ERRP_GUARD() = * * Without ERRP_GUARD(), use of the @errp parameter is restricted: * - It must not be dereferenced, because it may be null. * - It should not be passed to error_prepend() or * error_append_hint(), because that doesn't work with &error_fatal. * ERRP_GUARD() lifts these restrictions. No need to make an argument involving the possible arguments (pardon the pun). [...]