From: "Alex Bennée" <alex.bennee@linaro.org>
To: Sam Eiderman <sameid@google.com>
Cc: peter.maydell@linaro.org, thuth@redhat.com,
qemu-devel@nongnu.org, wainersm@redhat.com, crosa@redhat.com,
philmd@redhat.com
Subject: Re: gitlab-ci: Do not use the standard container images from gitlab
Date: Sat, 06 Jun 2020 12:49:40 +0100 [thread overview]
Message-ID: <87mu5gct2j.fsf@linaro.org> (raw)
In-Reply-To: <20200606100632.26442-1-sameid@google.com>
Sam Eiderman <sameid@google.com> writes:
> Hi,
>
> I am using debian 10 container to compile qemu too.
>
> I think that what happens here is that
>
> /usr/include/linux/swab.h
>
> Uses BITS_PER_LONG instead of __BITS_PER_LONG which is actually defined before
> in qemu at:
That is indeed the error - we are just waiting for Debian to update
linux-libc-dev with the fix to the kernel headers:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=960271
>
> include/qemu/bitops.h:#define BITS_PER_LONG (sizeof (unsigned long) * BITS_PER_BYTE)
>
> which injects this definition into the linux swab.h header.
>
> By changing BITS_PER_LONG to __BITS_PER_LONG in the linux headers, I managed to
> successfully compile qemu.
>
> A different approach would be to move the linux header includes
> (#include <linux/cdrom.h>) in file-posix.c above all other includes - which in
> some way makes more sense (since we probaly don't want qemu defines to control
> linux headers) but it requires a more complex refactoring.
--
Alex Bennée
next prev parent reply other threads:[~2020-06-06 11:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 10:10 [PULL 0/7] Gitlab CI fixes and improvements Thomas Huth
2020-05-28 10:10 ` [PULL 1/7] linux-user: limit check to HOST_LONG_BITS < TARGET_ABI_BITS Thomas Huth
2020-05-28 10:10 ` [PULL 2/7] MAINTAINERS: Add Philippe, Alex and Wainer to the Gitlab-CI section Thomas Huth
2020-05-28 10:10 ` [PULL 3/7] gitlab-ci: Remove flex/bison packages Thomas Huth
2020-05-28 10:10 ` [PULL 4/7] GitLab CI: avoid calling before_scripts on unintended jobs Thomas Huth
2020-05-28 10:10 ` [PULL 5/7] gitlab-ci: Move edk2 and opensbi YAML files to .gitlab-ci.d folder Thomas Huth
2020-10-12 13:44 ` Philippe Mathieu-Daudé
2020-10-12 14:01 ` Daniel P. Berrangé
2020-10-13 14:18 ` Philippe Mathieu-Daudé
2020-11-10 10:59 ` Philippe Mathieu-Daudé
2020-05-28 10:10 ` [PULL 6/7] gitlab-ci: Do not use the standard container images from gitlab Thomas Huth
2020-06-06 10:06 ` Sam Eiderman
2020-06-06 11:49 ` Alex Bennée [this message]
2020-06-06 12:38 ` Sam Eiderman
2020-06-07 5:39 ` Thomas Huth
2020-06-07 7:03 ` Sam Eiderman
2020-05-28 10:10 ` [PULL 7/7] gitlab-ci: Determine the number of jobs dynamically Thomas Huth
2020-05-28 16:05 ` [PULL 0/7] Gitlab CI fixes and improvements Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu5gct2j.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sameid@google.com \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.