All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andrey Konovalov <andreyknvl@google.com>,
	USB list <linux-usb@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [PATCH v2] usb: raw-gadget: fix gadget endpoint selection
Date: Tue, 12 May 2020 09:40:49 +0300	[thread overview]
Message-ID: <87mu6d4pvy.fsf@kernel.org> (raw)
In-Reply-To: <20200509170843.GD2482887@kroah.com>

[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]

Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:

> On Sat, May 09, 2020 at 11:02:13AM +0300, Felipe Balbi wrote:
>> 
>> Hi,
>> 
>> Andrey Konovalov <andreyknvl@google.com> writes:
>> >> here you're changing userspace ABI. Aren't we going to possibly break
>> >> some existing applications?
>> >
>> > Hi Felipe,
>> >
>> >  I've been working on tests for Raw Gadget for the last few weeks [1],
>> > which revealed a few problems with the interface. This isn't yet
>> > included into any released kernel, so my hope that changing the ABI is
>> > OK during the rc stage.
>> 
>> Fair enough. If that's okay with Greg, it's okay with me, but then how
>> do we include it into the -rc seen as it's not really a fix?
>> 
>> Greg, are you okay with me including such large patches during the -rc?
>> They essentially add new IOCTLs to the raw-gadget interface.
>
> Yes, as the driver only went in for -rc1, it's fine to add fixes like
> this so late as we don't want to ship a -final with it in broken form.

Thanks, I'll prepare a pull request containing it.

cheers

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

      reply	other threads:[~2020-05-12  6:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29 22:09 [PATCH v2] usb: raw-gadget: fix gadget endpoint selection Andrey Konovalov
2020-05-05  7:34 ` Felipe Balbi
2020-05-05 12:08   ` Andrey Konovalov
2020-05-05 15:26     ` Andrey Konovalov
2020-05-07 15:01       ` Andrey Konovalov
2020-05-09  8:02     ` Felipe Balbi
2020-05-09 17:08       ` Greg Kroah-Hartman
2020-05-12  6:40         ` Felipe Balbi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mu6d4pvy.fsf@kernel.org \
    --to=balbi@kernel.org \
    --cc=andreyknvl@google.com \
    --cc=dvyukov@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.