From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC41FC54FD0 for ; Mon, 27 Apr 2020 11:42:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC69B206D6 for ; Mon, 27 Apr 2020 11:42:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727099AbgD0LmV (ORCPT ); Mon, 27 Apr 2020 07:42:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727045AbgD0LmV (ORCPT ); Mon, 27 Apr 2020 07:42:21 -0400 Received: from Galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AAF8C0610D5; Mon, 27 Apr 2020 04:42:21 -0700 (PDT) Received: from p5de0bf0b.dip0.t-ipconnect.de ([93.224.191.11] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1jT29J-0001JG-W7; Mon, 27 Apr 2020 13:42:10 +0200 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id 66B12100606; Mon, 27 Apr 2020 13:42:09 +0200 (CEST) From: Thomas Gleixner To: Michael Walle , Andy Shevchenko , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Lee Jones , Thierry Reding , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Jason Cooper , Marc Zyngier , Mark Brown , Greg Kroah-Hartman , Michael Walle Subject: Re: [PATCH v3 09/16] gpiolib: Introduce gpiochip_irqchip_add_domain() In-Reply-To: <20200423174543.17161-10-michael@walle.cc> References: <20200423174543.17161-1-michael@walle.cc> <20200423174543.17161-10-michael@walle.cc> Date: Mon, 27 Apr 2020 13:42:09 +0200 Message-ID: <87mu6xqhny.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org Michael Walle writes: > This connects an IRQ domain to a gpiochip and reuses > gpiochip_to_irq(). A little bit more context and explanation why this function is useful would be appreciated. > Signed-off-by: Michael Walle > --- > drivers/gpio/gpiolib.c | 20 ++++++++++++++++++++ > include/linux/gpio/driver.h | 3 +++ > 2 files changed, 23 insertions(+) > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > index 40f2d7f69be2..7b3d7f496b9a 100644 > --- a/drivers/gpio/gpiolib.c > +++ b/drivers/gpio/gpiolib.c > @@ -2722,6 +2722,26 @@ int gpiochip_irqchip_add_key(struct gpio_chip *gc, > } > EXPORT_SYMBOL_GPL(gpiochip_irqchip_add_key); > > +/** > + * gpiochip_irqchip_add_key() - adds an irqdomain to a gpiochip Copy & paste is wonderful > + * @gc: the gpiochip to add the irqchip to > + * @domain: the irqdomain to add to the gpiochip > + * > + * This function adds an IRQ domain to the gpiochip. > + */ > +int gpiochip_irqchip_add_domain(struct gpio_chip *gc, > + struct irq_domain *domain) > +{ > + if (!domain) > + return -EINVAL; > + > + gc->to_irq = gpiochip_to_irq; > + gc->irq.domain = domain; > + > + return 0; > +} Thanks, tglx From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [PATCH v3 09/16] gpiolib: Introduce gpiochip_irqchip_add_domain() Date: Mon, 27 Apr 2020 13:42:09 +0200 Message-ID: <87mu6xqhny.fsf@nanos.tec.linutronix.de> References: <20200423174543.17161-1-michael@walle.cc> <20200423174543.17161-10-michael@walle.cc> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727045AbgD0LmV (ORCPT ); Mon, 27 Apr 2020 07:42:21 -0400 In-Reply-To: <20200423174543.17161-10-michael@walle.cc> Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: Andy Shevchenko , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Lee Jones , Thierry Reding , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Jason Cooper , Marc Zyngier , Mark Brown , Greg Kroah-Hartman , Michael Walle Michael Walle writes: > This connects an IRQ domain to a gpiochip and reuses > gpiochip_to_irq(). A little bit more context and explanation why this function is useful would be appreciated. > Signed-off-by: Michael Walle > --- > drivers/gpio/gpiolib.c | 20 ++++++++++++++++++++ > include/linux/gpio/driver.h | 3 +++ > 2 files changed, 23 insertions(+) > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > index 40f2d7f69be2..7b3d7f496b9a 100644 > --- a/drivers/gpio/gpiolib.c > +++ b/drivers/gpio/gpiolib.c > @@ -2722,6 +2722,26 @@ int gpiochip_irqchip_add_key(struct gpio_chip *gc, > } > EXPORT_SYMBOL_GPL(gpiochip_irqchip_add_key); > > +/** > + * gpiochip_irqchip_add_key() - adds an irqdomain to a gpiochip Copy & paste is wonderful > + * @gc: the gpiochip to add the irqchip to > + * @domain: the irqdomain to add to the gpiochip > + * > + * This function adds an IRQ domain to the gpiochip. > + */ > +int gpiochip_irqchip_add_domain(struct gpio_chip *gc, > + struct irq_domain *domain) > +{ > + if (!domain) > + return -EINVAL; > + > + gc->to_irq = gpiochip_to_irq; > + gc->irq.domain = domain; > + > + return 0; > +} Thanks, tglx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3AD8C55199 for ; Mon, 27 Apr 2020 11:42:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69D41206E9 for ; Mon, 27 Apr 2020 11:42:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MyqUQI2P" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69D41206E9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+/sU2iJdsJOosCkLcMseEx8Yd2lV3Lqz+4IGQ8pRodY=; b=MyqUQI2PG4Rojz CXBj3a8nYcbn+sVgqLSO2cZc9Zk8Rg/EBM895bGFjaENjoC6sPCCT8hs6gvuQRe7H4tz448/PYqa/ 1qxeLzi0H9NW7ktWOHATSGbfFNs+V4N53cNWj/96wV/K0l03WIbJxitC0im0EEtzqqEgYoPmGw+dr 8o/svnfUSR8f+zAOf6O6ut3TqJnSXq2O7+m2yR99/qm3Pi1KnYzUkKE31BGZPASiFI6s0p9NT177O gozL8V0jetQNCLGi2iR6/fzyYkJhpTRdUGpUk/Vj/6u8zLhc/fW730j5gLK6Y0BrhNGo0wuEmFF2m jrrE/8wy5gCscVhaKnPA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT29T-0005RK-0X; Mon, 27 Apr 2020 11:42:19 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT29O-0005Oq-DQ for linux-arm-kernel@lists.infradead.org; Mon, 27 Apr 2020 11:42:15 +0000 Received: from p5de0bf0b.dip0.t-ipconnect.de ([93.224.191.11] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1jT29J-0001JG-W7; Mon, 27 Apr 2020 13:42:10 +0200 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id 66B12100606; Mon, 27 Apr 2020 13:42:09 +0200 (CEST) From: Thomas Gleixner To: Michael Walle , Andy Shevchenko , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 09/16] gpiolib: Introduce gpiochip_irqchip_add_domain() In-Reply-To: <20200423174543.17161-10-michael@walle.cc> References: <20200423174543.17161-1-michael@walle.cc> <20200423174543.17161-10-michael@walle.cc> Date: Mon, 27 Apr 2020 13:42:09 +0200 Message-ID: <87mu6xqhny.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1, SHORTCIRCUIT=-0.0001 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200427_044214_601615_88FDFCF9 X-CRM114-Status: GOOD ( 17.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marc Zyngier , Jean Delvare , Jason Cooper , Greg Kroah-Hartman , Shawn Guo , Linus Walleij , Li Yang , Bartosz Golaszewski , Michael Walle , Rob Herring , Thierry Reding , Mark Brown , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Wim Van Sebroeck , Lee Jones , Guenter Roeck Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Michael Walle writes: > This connects an IRQ domain to a gpiochip and reuses > gpiochip_to_irq(). A little bit more context and explanation why this function is useful would be appreciated. > Signed-off-by: Michael Walle > --- > drivers/gpio/gpiolib.c | 20 ++++++++++++++++++++ > include/linux/gpio/driver.h | 3 +++ > 2 files changed, 23 insertions(+) > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > index 40f2d7f69be2..7b3d7f496b9a 100644 > --- a/drivers/gpio/gpiolib.c > +++ b/drivers/gpio/gpiolib.c > @@ -2722,6 +2722,26 @@ int gpiochip_irqchip_add_key(struct gpio_chip *gc, > } > EXPORT_SYMBOL_GPL(gpiochip_irqchip_add_key); > > +/** > + * gpiochip_irqchip_add_key() - adds an irqdomain to a gpiochip Copy & paste is wonderful > + * @gc: the gpiochip to add the irqchip to > + * @domain: the irqdomain to add to the gpiochip > + * > + * This function adds an IRQ domain to the gpiochip. > + */ > +int gpiochip_irqchip_add_domain(struct gpio_chip *gc, > + struct irq_domain *domain) > +{ > + if (!domain) > + return -EINVAL; > + > + gc->to_irq = gpiochip_to_irq; > + gc->irq.domain = domain; > + > + return 0; > +} Thanks, tglx _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel