From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FB26C2BA19 for ; Sun, 5 Apr 2020 08:45:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E762E20672 for ; Sun, 5 Apr 2020 08:45:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="WseyDcEV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726478AbgDEIpB (ORCPT ); Sun, 5 Apr 2020 04:45:01 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:16827 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726308AbgDEIpA (ORCPT ); Sun, 5 Apr 2020 04:45:00 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1586076300; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=YD+6B7bB8KDIMzLCo6S03UdZ+WXtGN9oqNBfZxnj7PU=; b=WseyDcEVh4sefHTKiIZiJ//HNIlOAy6p2zxT5sHyD8oJFrjIwtNMw8/A3vmmPn3gesXAI19a VtrPGl923Fmw0zAGNSLLQ7Y+T7++HNhAjxKIn1UbTRQqMh+RLeY0gntfu5/n7H/11rdDq/Xz i6pU013g0CcjU39wmhfH8A7/5Zg= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e899a8b.7fc9721a2538-smtp-out-n05; Sun, 05 Apr 2020 08:44:59 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id A02E7C43637; Sun, 5 Apr 2020 08:44:58 +0000 (UTC) Received: from x230.qca.qualcomm.com (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id BC38AC433F2; Sun, 5 Apr 2020 08:44:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BC38AC433F2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Chris Rorvick Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , "David S. Miller" Subject: Re: [PATCH] iwlwifi: actually check allocated conf_tlv pointer References: <20200402050219.4842-1-chris@rorvick.com> Date: Sun, 05 Apr 2020 11:44:53 +0300 In-Reply-To: <20200402050219.4842-1-chris@rorvick.com> (Chris Rorvick's message of "Thu, 2 Apr 2020 00:02:19 -0500") Message-ID: <87mu7qfhiy.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Chris Rorvick writes: > Commit 71bc0334a637 ("iwlwifi: check allocated pointer when allocating > conf_tlvs") attempted to fix a typoe introduced by commit 17b809c9b22e > ("iwlwifi: dbg: move debug data to a struct") but does not implement the > check correctly. > > Tweeted-by: @grsecurity > Signed-off-by: Chris Rorvick I'll add: Fixes: 71bc0334a637 ("iwlwifi: check allocated pointer when allocating conf_tlvs") > --- > In this wasn't picked up? Luca, can I take this directly? -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches