From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42BC7C432C0 for ; Mon, 18 Nov 2019 10:10:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 16C8320727 for ; Mon, 18 Nov 2019 10:10:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="T4005Zk9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726552AbfKRKKh (ORCPT ); Mon, 18 Nov 2019 05:10:37 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:59996 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726488AbfKRKKh (ORCPT ); Mon, 18 Nov 2019 05:10:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574071835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G45mRJb2R55hTpqWOgmQqio32gnIzC1eCmtGv4EySOk=; b=T4005Zk9b5okSvR7UIrqB8OMKUGFatc+7TMaFuYy4yGfP4rqv/N4cXmpe021/jcbi4UUqS 0YGRQy/JodIgBYjeZaEBjytMBFROtLUlYzbmiQJ6XsYSwI1PcT+pJa0S5un/8GXrwB20CQ d5+hvIsnbzRvlOLvH8md6lXC/SBt8QA= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-288-O5AGdHMWMGGmG_KY2qyv8A-1; Mon, 18 Nov 2019 05:10:32 -0500 Received: by mail-lj1-f199.google.com with SMTP id l12so3134609ljg.21 for ; Mon, 18 Nov 2019 02:10:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=OIQCTBj1ZZClWzpd5quqOflGEWiO+R0tbK558qeMbh4=; b=BD5V0q5hANewYJZ/8Q46hyTVIvFoFg1zPRPac478yOzrlVHJ9OzNPDp4ZTP2DrsE+8 XHSExIN35nKPX3nd1k6XKCFaTO7u/lap3qa28qfU+HAlhcF5gXbNhzN3ayPvyQPxqTiA d1u7VdWcSnUrXWFzsskOTd+VotbgUEJ73XNVyXOz4shqWBafzTFpxRw4yaJlVF5A8wK3 Fpq862I+KQcsRSSA7AN70L09zKC5b1C0Io7Ta7K64dz0Ra2/0vvXpmcoSob7WCZBpQU7 L3KAoQaoo6vzxeYM7vx74w9jxEapGirXdSSkYbw3q3aWbtoRFI5WDsK4uchs1WtTHbvf rwJQ== X-Gm-Message-State: APjAAAVRkF6R202HtZhauTwKCIeR5WD8e9DOOsptJj4cnW2icy0Ch4O8 rHgCp+PI4NmMAUhNz4I6LZWBNaoQkV2s1oP5K94/tG/rgyahZWNF+nl5o62ssdwanrTHsQ4Ndsq PaHdKDbyn+zlal7La+QOwcruKKXk= X-Received: by 2002:a05:651c:1109:: with SMTP id d9mr20056936ljo.192.1574071831434; Mon, 18 Nov 2019 02:10:31 -0800 (PST) X-Google-Smtp-Source: APXvYqyx34G0PV/fe8D53a+QUqfm/vO0wSGhLgSfIKtC5qf0UKXzF5h1YYJhlKi/PARk15AMZvmAJA== X-Received: by 2002:a05:651c:1109:: with SMTP id d9mr20056921ljo.192.1574071831296; Mon, 18 Nov 2019 02:10:31 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk (borgediget.toke.dk. [85.204.121.218]) by smtp.gmail.com with ESMTPSA id o196sm8775203lff.59.2019.11.18.02.10.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2019 02:10:30 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id DF6B118190D; Mon, 18 Nov 2019 11:10:29 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Kan Yan Cc: Johannes Berg , linux-wireless , Make-Wifi-fast , ath10k@lists.infradead.org, John Crispin , Lorenzo Bianconi , Felix Fietkau , Rajkumar Manoharan , Kevin Hayes Subject: Re: [PATCH v9 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue In-Reply-To: References: <157382403672.580235.12525941420808058808.stgit@toke.dk> <157382404118.580235.14216392299709793599.stgit@toke.dk> <87y2wgjas4.fsf@toke.dk> X-Clacks-Overhead: GNU Terry Pratchett Date: Mon, 18 Nov 2019 11:10:29 +0100 Message-ID: <87muctcx62.fsf@toke.dk> MIME-Version: 1.0 X-MC-Unique: O5AGdHMWMGGmG_KY2qyv8A-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Kan Yan writes: >> > Given the fact that AQL is only tested in very limited platforms, >> > should we set the default to disabled by removing this change in the >> > next update? >> > >> > - local->airtime_flags =3D AIRTIME_USE_TX | AIRTIME_USE_RX; >> > + >> > + local->airtime_flags =3D AIRTIME_USE_TX | >> > + AIRTIME_USE_RX | >> > + AIRTIME_USE_AQL; >> > + local->aql_threshold =3D IEEE80211_AQL_THRESHOLD; >> > + atomic_set(&local->aql_total_pending_airtime, 0); >> Well, we have the whole -rc series to get more testing in if we merge it >> as-is. It's up to the maintainers, of course, but I would be in favour >> of merging as-is, then optionally backing out the default before the >> final release if problems do turn up. But I would hope that the limits >> are sufficiently conservative that it would not result in any problems := ) > > Sounds good. The current default limits are reasonably conservative > and are tunable via debugfs. > > I will give the v10 version of this patch serial a quick test and > hopefully we can wrap it up soon. Sounds good, thanks! Also, seems we got a 5.4-rc8 yesterday, so we have another week before the merge window. Johannes, any chance you'll get a chance to take a look at this sometime this week? :) -Toke From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120] helo=us-smtp-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWdzU-0002tI-SP for ath10k@lists.infradead.org; Mon, 18 Nov 2019 10:10:43 +0000 Received: by mail-lf1-f72.google.com with SMTP id f20so1022335lfh.7 for ; Mon, 18 Nov 2019 02:10:32 -0800 (PST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Subject: Re: [PATCH v9 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue In-Reply-To: References: <157382403672.580235.12525941420808058808.stgit@toke.dk> <157382404118.580235.14216392299709793599.stgit@toke.dk> <87y2wgjas4.fsf@toke.dk> Date: Mon, 18 Nov 2019 11:10:29 +0100 Message-ID: <87muctcx62.fsf@toke.dk> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kan Yan Cc: Rajkumar Manoharan , Kevin Hayes , Make-Wifi-fast , linux-wireless , ath10k@lists.infradead.org, John Crispin , Johannes Berg , Lorenzo Bianconi , Felix Fietkau Kan Yan writes: >> > Given the fact that AQL is only tested in very limited platforms, >> > should we set the default to disabled by removing this change in the >> > next update? >> > >> > - local->airtime_flags = AIRTIME_USE_TX | AIRTIME_USE_RX; >> > + >> > + local->airtime_flags = AIRTIME_USE_TX | >> > + AIRTIME_USE_RX | >> > + AIRTIME_USE_AQL; >> > + local->aql_threshold = IEEE80211_AQL_THRESHOLD; >> > + atomic_set(&local->aql_total_pending_airtime, 0); >> Well, we have the whole -rc series to get more testing in if we merge it >> as-is. It's up to the maintainers, of course, but I would be in favour >> of merging as-is, then optionally backing out the default before the >> final release if problems do turn up. But I would hope that the limits >> are sufficiently conservative that it would not result in any problems :) > > Sounds good. The current default limits are reasonably conservative > and are tunable via debugfs. > > I will give the v10 version of this patch serial a quick test and > hopefully we can wrap it up soon. Sounds good, thanks! Also, seems we got a 5.4-rc8 yesterday, so we have another week before the merge window. Johannes, any chance you'll get a chance to take a look at this sometime this week? :) -Toke _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k