From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCF0BC4360C for ; Fri, 11 Oct 2019 01:39:30 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EAAA21920 for ; Fri, 11 Oct 2019 01:39:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Pdlq0x3R" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EAAA21920 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3EBA31615; Fri, 11 Oct 2019 03:38:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3EBA31615 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1570757968; bh=H9eulC3Otg8i7+rWpCUqM338VNwZUfHa8gsRdmSFaA8=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Pdlq0x3RS3FY0F58hd5RG+QKsMXGLfmCNVSOV21GlnEJuwErWNz4ihLrDOifH2mlu Ly8gqnv40hdxsjcT5vwfNrgSS5R5XE/miliG1exN5bJvn1XD4DgiRCWd5pW7s6mkwH 4S1rDzTv5aSlQB/jjh9jNSBfWc7aGcb3JLBPgeB8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D3975F802BD; Fri, 11 Oct 2019 03:38:37 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 772FFF802BE; Fri, 11 Oct 2019 03:38:36 +0200 (CEST) Received: from relmlie6.idc.renesas.com (relmlor2.renesas.com [210.160.252.172]) by alsa1.perex.cz (Postfix) with ESMTP id 8E760F800E3 for ; Fri, 11 Oct 2019 03:38:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8E760F800E3 Date: 11 Oct 2019 10:38:28 +0900 X-IronPort-AV: E=Sophos;i="5.67,282,1566831600"; d="scan'208";a="28610244" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie6.idc.renesas.com with ESMTP; 11 Oct 2019 10:38:28 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id 6260040B8E11; Fri, 11 Oct 2019 10:38:28 +0900 (JST) Message-ID: <87mue8vz6z.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Pierre-Louis Bossart In-Reply-To: <562d76de-c724-e98b-ce7d-105a88bf17ce@linux.intel.com> References: <87sgo2ilso.wl-kuninori.morimoto.gx@renesas.com> <87bluqilqm.wl-kuninori.morimoto.gx@renesas.com> <562d76de-c724-e98b-ce7d-105a88bf17ce@linux.intel.com> User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Cc: Linux-ALSA , Mark Brown Subject: Re: [alsa-devel] [PATCH 12/21] ASoC: soc-core: use snd_soc_lookup_component() at snd_soc_unregister_component() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Pierre-Louis > > +void snd_soc_unregister_component(struct device *dev) > > { > > struct snd_soc_component *component; > > - int found = 0; > > - > > - mutex_lock(&client_mutex); > > - for_each_component(component) { > > - if (dev != component->dev) > > - continue; > > + while (1) { > > + component = snd_soc_lookup_component(dev, NULL); > > + if (!component) > > + break; > > snd_soc_del_component(component); > > is it ok/intended that the mutex lock is now taken *after* looking up > the component and after each iteration ? Hmm.. maybe not good. I will keep _unlocked() naming and mutex Thank you for your help !! Best regards --- Kuninori Morimoto _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel