All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Fam Zheng" <fam@euphon.net>,
	qemu-block@nongnu.org, "Michael Roth" <mdroth@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Max Reitz" <mreitz@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Stefan Berger" <stefanb@linux.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v3 1/5] socket: Add backlog parameter to socket_listen
Date: Tue, 20 Aug 2019 13:17:59 +0200	[thread overview]
Message-ID: <87mug4xezc.fsf@trasno.org> (raw)
In-Reply-To: <20190820105034.GG23352@redhat.com> ("Daniel P. =?utf-8?Q?Ber?= =?utf-8?Q?rang=C3=A9=22's?= message of "Tue, 20 Aug 2019 11:50:34 +0100")

Daniel P. Berrangé <berrange@redhat.com> wrote:
> On Tue, Aug 20, 2019 at 12:48:32PM +0200, Juan Quintela wrote:
>> Current parameter was always one.  We continue with that value for now
>> in all callers.
>> 
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> 
>> ---
>> Moved trace to socket_listen
>> ---
>>  include/qemu/sockets.h    |  2 +-
>>  io/channel-socket.c       |  2 +-
>>  qga/channel-posix.c       |  2 +-
>>  tests/test-util-sockets.c | 12 ++++++------
>>  util/qemu-sockets.c       | 33 ++++++++++++++++++++++-----------
>>  util/trace-events         |  3 +++
>>  6 files changed, 34 insertions(+), 20 deletions(-)
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Hi

Everything is reviewed by you, and it is mostly socket code.  Should I
do the pull request, or are you doing it?

Thanks, Juan.


  reply	other threads:[~2019-08-20 11:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-20 10:48 [Qemu-devel] [PATCH v3 0/5] Fix multifd with big number of channels Juan Quintela
2019-08-20 10:48 ` [Qemu-devel] [PATCH v3 1/5] socket: Add backlog parameter to socket_listen Juan Quintela
2019-08-20 10:50   ` Daniel P. Berrangé
2019-08-20 11:17     ` Juan Quintela [this message]
2019-08-22 14:19       ` Daniel P. Berrangé
2019-08-20 10:48 ` [Qemu-devel] [PATCH v3 2/5] socket: Add num connections to qio_channel_socket_sync() Juan Quintela
2019-08-20 10:48 ` [Qemu-devel] [PATCH v3 3/5] socket: Add num connections to qio_channel_socket_async() Juan Quintela
2019-08-20 10:48 ` [Qemu-devel] [PATCH v3 4/5] socket: Add num connections to qio_net_listener_open_sync() Juan Quintela
2019-09-04 12:39   ` Eric Blake
2019-09-04 13:19     ` Juan Quintela
2019-09-04 13:57       ` Daniel P. Berrangé
2019-08-20 10:48 ` [Qemu-devel] [PATCH v3 5/5] multifd: Use number of channels as listen backlog Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mug4xezc.fsf@trasno.org \
    --to=quintela@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=fam@euphon.net \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanb@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.