From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E5CBC04E84 for ; Tue, 28 May 2019 08:12:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1AA6C20883 for ; Tue, 28 May 2019 08:12:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AA6C20883 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:58881 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVXDl-0002MT-B8 for qemu-devel@archiver.kernel.org; Tue, 28 May 2019 04:12:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51375) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVXCX-0001mK-QZ for qemu-devel@nongnu.org; Tue, 28 May 2019 04:11:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVXCW-0002a2-UC for qemu-devel@nongnu.org; Tue, 28 May 2019 04:11:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4405) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hVXCW-0002Yv-Pn for qemu-devel@nongnu.org; Tue, 28 May 2019 04:11:16 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2FD497FDFD; Tue, 28 May 2019 08:11:15 +0000 (UTC) Received: from redhat.com (unknown [10.36.118.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B4F681001E60; Tue, 28 May 2019 08:11:13 +0000 (UTC) From: Juan Quintela To: Wei Yang In-Reply-To: <20190528014703.21030-2-richardw.yang@linux.intel.com> (Wei Yang's message of "Tue, 28 May 2019 09:47:00 +0800") References: <20190528014703.21030-1-richardw.yang@linux.intel.com> <20190528014703.21030-2-richardw.yang@linux.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Date: Tue, 28 May 2019 10:11:11 +0200 Message-ID: <87muj780dc.fsf@trasno.org> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 28 May 2019 08:11:15 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 1/4] migration: multifd_save_setup always return 0 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Cc: qemu-devel@nongnu.org, dgilbert@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Wei Yang wrote: > Signed-off-by: Wei Yang > --- > migration/migration.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/migration/migration.c b/migration/migration.c > index d0a0f68f11..3aae4f2734 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -3336,12 +3336,7 @@ void migrate_fd_connect(MigrationState *s, Error *error_in) > return; > } > > - if (multifd_save_setup() != 0) { > - migrate_set_state(&s->state, MIGRATION_STATUS_SETUP, > - MIGRATION_STATUS_FAILED); > - migrate_fd_cleanup(s); > - return; > - } > + multifd_save_setup(); > qemu_thread_create(&s->thread, "live_migration", migration_thread, s, > QEMU_THREAD_JOINABLE); > s->migration_thread_running = true; Nack. On the compression patches that are on list, multifd_save_setup() returns -1 if there is a problem when we allocate a zbuff.