All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org
Cc: Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH] mac80211: TDLS: fix skb queue/priority assignment
Date: Fri, 28 Sep 2018 11:04:23 +0200	[thread overview]
Message-ID: <87mus2at7s.fsf@toke.dk> (raw)
In-Reply-To: <1538119050.14416.55.camel@sipsolutions.net>

Johannes Berg <johannes@sipsolutions.net> writes:

> On Wed, 2018-09-05 at 14:50 +0200, Toke Høiland-Jørgensen wrote:
>
> (uh, sorry, bit late ...)
>
>> > The problem isn't so much how we handle it in mac80211 for the queueing,
>> > but how we deal with things like A-MSDU and how we present it to the
>> > driver ... for iwlwifi at least we'd really like to have only data
>> > frames so we can map it directly to the hardware queue ...
>> 
>> Ah, I see. No, then just putting them at the head of a different TXQ
>> probably won't work...
>> 
>> Are you mapping TXQs to hardware queues dynamically as they empty and
>> re-fill? Presumably you'll have cases where you don't have enough HWQs?
>
> Depends on the hardware. Newer hardware has basically unlimited HWQs
> (something on the order of 512 IIRC).
>
> Older hardware sort of maps them dynamically, but not too dynamic, we
> also have 32 (ish) queues there. We only free them if we need a new one
> and don't have one, and yes, theoretically we can run out and then we
> may have to share a single hardware queue for multiple TXQs, but it
> basically never happens in practice.

Right, gotcha, thanks for the explanation :)

-Toke

      reply	other threads:[~2018-09-28  9:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-05 11:34 [PATCH] mac80211: TDLS: fix skb queue/priority assignment Johannes Berg
2018-09-05 11:37 ` Johannes Berg
2018-09-05 11:40   ` Toke Høiland-Jørgensen
2018-09-05 11:41     ` Johannes Berg
2018-09-05 11:44       ` Johannes Berg
2018-09-05 12:32         ` Toke Høiland-Jørgensen
2018-09-05 12:33           ` Johannes Berg
2018-09-05 12:50             ` Toke Høiland-Jørgensen
2018-09-28  7:17               ` Johannes Berg
2018-09-28  9:04                 ` Toke Høiland-Jørgensen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mus2at7s.fsf@toke.dk \
    --to=toke@toke.dk \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@nbd.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.