Re: [PATCH 0/5] staging: mt7621-gpio: some driver cleanups

[NeilBrown <neil@brown.name>]

[-- Attachment #1.1: Type: text/plain, Size: 1481 bytes --]

On Mon, May 14 2018, Sergio Paracuellos wrote:

> The following patch series fix all remaining checkpatch complains
> about this driver. Changes have not been tested and also compiled
> but it should not have any problem about them.

Thanks for these.  As you say, nothing in them could change behaviour of
the driver, but I tested them anyway and gpio still works (both in and
out) - no surprises.

I can give
  Reviewed-by: NeilBrown <neil@brown.name>
for all exect "dt-bindings: gpio: add documentation for mt7621-gpio".
I'll reply to the separately.

Of course the dt-binding patches will need broader review once they seem
ready to us.

Thanks,
NeilBrown


>
> Sergio Paracuellos (5):
>   staging: mt7621-gpio: fix some warnings because of lines exceded 80
>     characters
>   staging: mt7621-gpio: add SPDX identifier
>   dt-bindings: add compatible string for 'mtk' MediaTek
>   dt-bindings: gpio: add documentation for mt7621-gpio
>   staging: mt7621-gpio: remove device tree related stuff from TODO file
>
>  .../devicetree/bindings/gpio/mtk,mt7621-gpio.txt   | 51 ++++++++++++++++++++++
>  .../devicetree/bindings/vendor-prefixes.txt        |  1 +
>  drivers/staging/mt7621-gpio/TODO                   |  1 -
>  drivers/staging/mt7621-gpio/gpio-mt7621.c          | 24 +++++-----
>  4 files changed, 66 insertions(+), 11 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/gpio/mtk,mt7621-gpio.txt
>
> -- 
> 2.7.4

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 169 bytes --]

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel