From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60371) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejyRX-00075N-R1 for qemu-devel@nongnu.org; Thu, 08 Feb 2018 21:29:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ejyRT-0000l4-Kz for qemu-devel@nongnu.org; Thu, 08 Feb 2018 21:29:39 -0500 Received: from mav.lukeshu.com ([104.207.138.63]:42890) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ejyRT-0000jZ-Gg for qemu-devel@nongnu.org; Thu, 08 Feb 2018 21:29:35 -0500 Date: Thu, 08 Feb 2018 21:29:26 -0500 Message-ID: <87mv0i6gl5.wl-lukeshu@lukeshu.com> From: Luke Shumaker In-Reply-To: <20171228180814.9749-1-lukeshu@lukeshu.com> References: <20171228180814.9749-1-lukeshu@lukeshu.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Qemu-devel] [PATCH 00/10] linux-user: Speed up guest space initialization on 32-bit ARM target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Riku Voipio , Laurent Vivier Ping. On Thu, 28 Dec 2017 13:08:03 -0500, Luke Shumaker wrote: > > From: Luke Shumaker > > The goal of this patchset is to fix > https://bugs.launchpad.net/qemu/+bug/1740219 > > The gist is that the current linear search for an acceptable address > range is a bad strategy when the reason we didn't get a good address > on the first try is that we've having problems mapping the commpage > for the 32-bit ARM target; especially if ASLR is disabled. > > I think that only the final patch in this patchset is actually > necessary to fix the issue; but I didn't feel comfortable writing it > without also makeing the preceding (small) changes. > > Luke Shumaker (10): > linux-user: Use #if to only call validate_guest_space for 32-bit ARM > target > linux-user: Rename validate_guest_space => init_guest_commpage > linux-user: init_guest_space: Clean up if we can't initialize the > commpage > linux-user: init_guest_space: Correctly handle guest_start in commpage > initialization > linux-user: init_guest_space: Clarify page alignment logic > linux-user: init_guest_commpage: Add a comment about size check > linux-user: init_guest_space: Clean up control flow a bit > linux-user: init_guest_space: Don't try to align if we'll reject it > linux-user: init_guest_space: Add a comment about search strategy > linux-user: init_guest_space: Try to make ARM space+commpage > continuous > > linux-user/elfload.c | 145 ++++++++++++++++++++++++++++++++++++++++----------- > 1 file changed, 114 insertions(+), 31 deletions(-) > > -- > 2.15.1 > > Happy hacking, > ~ Luke Shumaker >