From: Kalle Valo <kvalo@codeaurora.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [RFC 2/2] wl3501_cs: reduce stack size for KASAN
Date: Tue, 25 Jul 2017 15:52:00 +0300 [thread overview]
Message-ID: <87mv7sisr3.fsf@codeaurora.org> (raw)
In-Reply-To: <20170710144425.2238584-2-arnd@arndb.de> (Arnd Bergmann's message of "Mon, 10 Jul 2017 16:44:25 +0200")
Arnd Bergmann <arnd@arndb.de> writes:
> Inlining functions with local variables can lead to excessive stack usage
> with KASAN after a previous patch that modifies the outsb/insb helpers
> on x86.
>
> drivers/net/wireless/wl3501_cs.c: In function 'wl3501_rx_interrupt':
> drivers/net/wireless/wl3501_cs.c:1103:1: error: the frame size of 2232 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]
>
> Marking the two callers of insb/outb 'noinline' prevents the compiler
> from adding up the stack usage for each of the local variables passed
> into those, reducing the maximum stack frame size to 800 bytes with
> KASAN again.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Arnd, based on the discussion I'm dropping. Please let me know if I
should take this still.
--
Kalle Valo
next prev parent reply other threads:[~2017-07-25 12:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 14:44 [RFC 1/2] x86: mark target address as output in 'insb' asm Arnd Bergmann
2017-07-10 14:44 ` [RFC 2/2] wl3501_cs: reduce stack size for KASAN Arnd Bergmann
2017-07-25 12:52 ` Kalle Valo [this message]
2017-07-25 14:50 ` Arnd Bergmann
2017-07-12 13:10 ` [tip:x86/urgent] x86/io: Mark target address as output in 'insb()' asm tip-bot for Arnd Bergmann
2017-07-12 16:57 ` Linus Torvalds
2017-07-12 19:24 ` Ingo Molnar
2017-07-12 21:47 ` Arnd Bergmann
2017-07-12 22:43 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mv7sisr3.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arnd@arndb.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.