All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: yamada.masahiro@socionext.com, mmarek@suse.com,
	will.deacon@arm.com, peterz@infradead.org, boqun.feng@gmail.com,
	mingo@redhat.com, daniel.lezcano@linaro.org, tglx@linutronix.de,
	jason@lakedaemon.net, marc.zyngier@arm.com,
	gregkh@linuxfoundation.org, jslaby@suse.com, davem@davemloft.net,
	mchehab@kernel.org, sfr@canb.auug.org.au, fweisbec@gmail.com,
	viro@zeniv.linux.org.uk, mcgrof@kernel.org, dledford@redhat.com,
	bart.vanassche@sandisk.com, sstabellini@kernel.org,
	daniel.vetter@ffwll.ch, msalter@redhat.com,
	nicolas.dichtel@6wind.com, james.hogan@imgtec.com,
	paul.gortmaker@windriver.com, linux@roeck-us.net,
	heiko.carstens@de.ibm.com, schwidefsky@de.ibm.com,
	linux-kernel@vger.kernel.org, patches@groups.riscv.org,
	akpm@linux-foundation.org, albert@sifive.com
Subject: Re: [PATCH 17/17] RISC-V: Build Infastructure
Date: Wed, 12 Jul 2017 20:44:11 +1000	[thread overview]
Message-ID: <87mv8akk90.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <mhng-98cc8b2d-86fe-419e-9b0c-3e7f3bc80c48@palmer-si-x1c4>

Palmer Dabbelt <palmer@dabbelt.com> writes:
> On Mon, 10 Jul 2017 23:31:18 PDT (-0700), mpe@ellerman.id.au wrote:
...
>> So if you have a functional early console (which I think you do) then
>> you might be better off just making this def_bool y.
>
> I think that's best.  The SBI's EARLY_PRINTK support is quite clean, so I don't
> see any reason to disable it.  How does this look?

LGTM.

cheers

>   diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
>   index 366f5f2cf106..cc274bbc29a7 100644
>   --- a/arch/riscv/Kconfig
>   +++ b/arch/riscv/Kconfig
>   @@ -268,18 +268,7 @@ config CMDLINE_OVERRIDE
>             If you don't know what to do here, say N.
>
>    config EARLY_PRINTK
>   -       bool "Early printk"
>   -       default n
>   -       help
>   -         This option enables special console drivers which allow the kernel
>   -         to print messages very early in the bootup process.
>   -
>   -         This is useful for kernel debugging when your machine crashes very
>   -         early before the console code is initialized. For normal operation
>   -         it is not recommended because it looks ugly and doesn't cooperate
>   -         with klogd/syslogd or the X server. You should normally N here,
>   -         unless you want to debug such a crash.
>   -
>   +       def_bool y
>
>    source "lib/Kconfig.debug"

  reply	other threads:[~2017-07-12 10:44 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-11  1:39 RISC-V Linux Port v5 Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 01/17] lib: Add shared copies of some GCC library routines Palmer Dabbelt
2017-07-11  2:02   ` Stephen Rothwell
2017-07-11  2:03     ` Randy Dunlap
2017-07-11  2:09       ` [patches] " Palmer Dabbelt
2017-07-11  2:13         ` Randy Dunlap
2017-07-11  2:09     ` Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 02/17] pci: Add a generic, weakly-linked pcibios_align_resource Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 03/17] pci: Add a generic, weakly-linked pcibios_fixup_bus Palmer Dabbelt
2017-07-11 18:51   ` Luis R. Rodriguez
2017-07-11  1:39 ` [PATCH 04/17] MAINTAINERS: Add RISC-V Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 05/17] clocksource: New RISC-V SBI timer driver Palmer Dabbelt
2017-07-31 11:00   ` Daniel Lezcano
2017-08-01  1:14     ` Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 06/17] irqchip: RISC-V Local Interrupt Controller Driver Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 07/17] irqchip: New RISC-V PLIC Driver Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 08/17] tty: New RISC-V SBI console driver Palmer Dabbelt
2017-07-11  6:21   ` Michael Ellerman
2017-07-11 16:22     ` Palmer Dabbelt
2017-07-12 11:04       ` Michael Ellerman
2017-07-12 16:24         ` Palmer Dabbelt
2017-07-13 11:59           ` Michael Ellerman
2017-07-13 12:32             ` James Hogan
2017-07-13 21:50               ` Palmer Dabbelt
2017-07-14  5:07                 ` Michael Ellerman
2017-07-11  1:39 ` [PATCH 09/17] RISC-V: Init and Halt Code Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 10/17] RISC-V: Atomic and Locking Code Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 11/17] RISC-V: Generic library routines and assembly Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 12/17] RISC-V: ELF and module implementation Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 13/17] RISC-V: Task implementation Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 14/17] RISC-V: Device, timer, IRQs, and the SBI Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 15/17] RISC-V: Paging and MMU Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 16/17] RISC-V: User-facing API Palmer Dabbelt
2017-07-11 13:39   ` Christoph Hellwig
2017-07-11 14:01     ` James Hogan
2017-07-11 17:28       ` [patches] " Palmer Dabbelt
2017-07-11  1:39 ` [PATCH 17/17] RISC-V: Build Infastructure Palmer Dabbelt
2017-07-11  6:31   ` Michael Ellerman
2017-07-11 16:22     ` Palmer Dabbelt
2017-07-12 10:44       ` Michael Ellerman [this message]
2017-07-11 18:39 ` RISC-V Linux Port v5 Luis R. Rodriguez
2017-07-11 19:50   ` Palmer Dabbelt
2017-07-12  1:31 RISC-V Linux Port v6 Palmer Dabbelt
2017-07-12  1:31 ` [PATCH 17/17] RISC-V: Build Infastructure Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mv8akk90.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=akpm@linux-foundation.org \
    --cc=albert@sifive.com \
    --cc=bart.vanassche@sandisk.com \
    --cc=boqun.feng@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=davem@davemloft.net \
    --cc=dledford@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=james.hogan@imgtec.com \
    --cc=jason@lakedaemon.net \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=marc.zyngier@arm.com \
    --cc=mcgrof@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mingo@redhat.com \
    --cc=mmarek@suse.com \
    --cc=msalter@redhat.com \
    --cc=nicolas.dichtel@6wind.com \
    --cc=palmer@dabbelt.com \
    --cc=patches@groups.riscv.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=peterz@infradead.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=sfr@canb.auug.org.au \
    --cc=sstabellini@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=viro@zeniv.linux.org.uk \
    --cc=will.deacon@arm.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.