From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751585AbdFAKHd (ORCPT ); Thu, 1 Jun 2017 06:07:33 -0400 Received: from ozlabs.org ([103.22.144.67]:39641 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751346AbdFAKHb (ORCPT ); Thu, 1 Jun 2017 06:07:31 -0400 From: Michael Ellerman To: Yury Norov , Heiko Carstens Cc: Johannes Weiner , Josef Bacik , Michal Hocko , Vladimir Davydov , Andrew Morton , Rik van Riel , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, linux-s390@vger.kernel.org Subject: Re: [PATCH 2/6] mm: vmstat: move slab statistics from zone to node counters In-Reply-To: <20170531171151.e4zh7ffzbl4w33gd@yury-thinkpad> References: <20170530181724.27197-1-hannes@cmpxchg.org> <20170530181724.27197-3-hannes@cmpxchg.org> <20170531091256.GA5914@osiris> <20170531113900.GB5914@osiris> <20170531171151.e4zh7ffzbl4w33gd@yury-thinkpad> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Thu, 01 Jun 2017 20:07:28 +1000 Message-ID: <87mv9s2f8f.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Yury Norov writes: > On Wed, May 31, 2017 at 01:39:00PM +0200, Heiko Carstens wrote: >> On Wed, May 31, 2017 at 11:12:56AM +0200, Heiko Carstens wrote: >> > On Tue, May 30, 2017 at 02:17:20PM -0400, Johannes Weiner wrote: >> > > To re-implement slab cache vs. page cache balancing, we'll need the >> > > slab counters at the lruvec level, which, ever since lru reclaim was >> > > moved from the zone to the node, is the intersection of the node, not >> > > the zone, and the memcg. >> > > >> > > We could retain the per-zone counters for when the page allocator >> > > dumps its memory information on failures, and have counters on both >> > > levels - which on all but NUMA node 0 is usually redundant. But let's >> > > keep it simple for now and just move them. If anybody complains we can >> > > restore the per-zone counters. >> > > >> > > Signed-off-by: Johannes Weiner >> > >> > This patch causes an early boot crash on s390 (linux-next as of today). >> > CONFIG_NUMA on/off doesn't make any difference. I haven't looked any >> > further into this yet, maybe you have an idea? > > The same on arm64. And powerpc. cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Michael Ellerman Subject: Re: [PATCH 2/6] mm: vmstat: move slab statistics from zone to node counters In-Reply-To: <20170531171151.e4zh7ffzbl4w33gd@yury-thinkpad> References: <20170530181724.27197-1-hannes@cmpxchg.org> <20170530181724.27197-3-hannes@cmpxchg.org> <20170531091256.GA5914@osiris> <20170531113900.GB5914@osiris> <20170531171151.e4zh7ffzbl4w33gd@yury-thinkpad> Date: Thu, 01 Jun 2017 20:07:28 +1000 Message-ID: <87mv9s2f8f.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: owner-linux-mm@kvack.org List-Archive: List-Post: To: Yury Norov , Heiko Carstens Cc: Johannes Weiner , Josef Bacik , Michal Hocko , Vladimir Davydov , Andrew Morton , Rik van Riel , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, linux-s390@vger.kernel.org List-ID: Yury Norov writes: > On Wed, May 31, 2017 at 01:39:00PM +0200, Heiko Carstens wrote: >> On Wed, May 31, 2017 at 11:12:56AM +0200, Heiko Carstens wrote: >> > On Tue, May 30, 2017 at 02:17:20PM -0400, Johannes Weiner wrote: >> > > To re-implement slab cache vs. page cache balancing, we'll need the >> > > slab counters at the lruvec level, which, ever since lru reclaim was >> > > moved from the zone to the node, is the intersection of the node, not >> > > the zone, and the memcg. >> > > >> > > We could retain the per-zone counters for when the page allocator >> > > dumps its memory information on failures, and have counters on both >> > > levels - which on all but NUMA node 0 is usually redundant. But let's >> > > keep it simple for now and just move them. If anybody complains we can >> > > restore the per-zone counters. >> > > >> > > Signed-off-by: Johannes Weiner >> > >> > This patch causes an early boot crash on s390 (linux-next as of today). >> > CONFIG_NUMA on/off doesn't make any difference. I haven't looked any >> > further into this yet, maybe you have an idea? > > The same on arm64. And powerpc. cheers -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Subject: Re: [PATCH 2/6] mm: vmstat: move slab statistics from zone to node counters Date: Thu, 01 Jun 2017 20:07:28 +1000 Message-ID: <87mv9s2f8f.fsf@concordia.ellerman.id.au> References: <20170530181724.27197-1-hannes@cmpxchg.org> <20170530181724.27197-3-hannes@cmpxchg.org> <20170531091256.GA5914@osiris> <20170531113900.GB5914@osiris> <20170531171151.e4zh7ffzbl4w33gd@yury-thinkpad> Mime-Version: 1.0 Return-path: In-Reply-To: <20170531171151.e4zh7ffzbl4w33gd@yury-thinkpad> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yury Norov , Heiko Carstens Cc: Johannes Weiner , Josef Bacik , Michal Hocko , Vladimir Davydov , Andrew Morton , Rik van Riel , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-team-b10kYP2dOMg@public.gmane.org, linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Yury Norov writes: > On Wed, May 31, 2017 at 01:39:00PM +0200, Heiko Carstens wrote: >> On Wed, May 31, 2017 at 11:12:56AM +0200, Heiko Carstens wrote: >> > On Tue, May 30, 2017 at 02:17:20PM -0400, Johannes Weiner wrote: >> > > To re-implement slab cache vs. page cache balancing, we'll need the >> > > slab counters at the lruvec level, which, ever since lru reclaim was >> > > moved from the zone to the node, is the intersection of the node, not >> > > the zone, and the memcg. >> > > >> > > We could retain the per-zone counters for when the page allocator >> > > dumps its memory information on failures, and have counters on both >> > > levels - which on all but NUMA node 0 is usually redundant. But let's >> > > keep it simple for now and just move them. If anybody complains we can >> > > restore the per-zone counters. >> > > >> > > Signed-off-by: Johannes Weiner >> > >> > This patch causes an early boot crash on s390 (linux-next as of today). >> > CONFIG_NUMA on/off doesn't make any difference. I haven't looked any >> > further into this yet, maybe you have an idea? > > The same on arm64. And powerpc. cheers