From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932815AbcGOKjY (ORCPT <rfc822;w@1wt.eu>);
	Fri, 15 Jul 2016 06:39:24 -0400
Received: from mga01.intel.com ([192.55.52.88]:32182 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932561AbcGOKjM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 15 Jul 2016 06:39:12 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,367,1464678000"; 
   d="asc'?scan'208";a="734657654"
From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Bin Gao <bin.gao@linux.intel.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Bin Gao <bin.gao@intel.com>,
        Chandra Sekhar Anagani <chandra.sekhar.anagani@intel.com>
Subject: Re: [PATCH 1/2] usb: typec: Add USB Power Delivery sink port support
In-Reply-To: <20160715021405.GB128987@worksta>
References: <20160715021405.GB128987@worksta>
User-Agent: Notmuch/0.22+58~g3a45d29 (https://notmuchmail.org) Emacs/25.0.95.2 (x86_64-pc-linux-gnu)
Date: Fri, 15 Jul 2016 13:38:12 +0300
Message-ID: <87mvljgp9n.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Bin Gao <bin.gao@linux.intel.com> writes:
> +static void print_message(int port, bool is_cmsg, u8 msg, bool recv)
> +{
> +	pr_info("sink port %d: %s message %s %s\n", port,
> +				is_cmsg ? "Control" : "Data",
> +				msg_to_string(is_cmsg, msg),
> +		 recv ? "received" : "sent(wait GOODCRC)");
> +}

this is problematic. By default, we're all using 115200 8N1 baud
rate. This message alone prints anywhere from 50 to 100 characters (I
didn't really count properly, these are rough numbers), and that takes:

n50chars_time =3D 50 / (115200 / 10) =3D 4.3ms
n100chars_time =3D 100 / (115200 / 10) =3D 8.6ms

Considering you have 30ms to reply with Power Request after GoodCRC, and
considering you're printing several of these messages, they become
really expensive and eat up valuable time from tSenderReply.

This should really be a pr_debug() or, better yet, a tracepoint.

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXiL0UAAoJEIaOsuA1yqREJuMP/RbcK/ZI3IYgQhf9bSMquF0A
INHp04iUaklc5wql1UbAX9S3YLwdz+7kgGm9PAjAcuKA2lTo1Y7vfHCd1BMnA5UA
zd6YeeXe87hhjncHnhTYSmToGWBf2c7KlQ2JZU2bMOpnbWqTBH00k2u6VlhrDe2+
ywZKJN2duMZulw0D+c2KNV3SYIVpKGmUnlDDUJyTNwuvXNnM6S8yA2wSiMYeVgpF
cRFsdZjzq7oGnNafZq8UdXkCM8dXknxZBwLVpphhNoPJei2r1Mr9CGHWuosoMwIe
WLHqQ3NIOTBsBKn7UiAALLJPi3RHJzyD4qX6V4Ay1v4qngELzoiYJOs1O6rjO94J
raJOiCWkno1URE0KX6jc4FE6LvsVreNUijds77INQh5aSf1dNTpmM2KQCzm0ZB1u
IL2FUWFwICYap6uLeatatReS267FWPw3TRyFDZrq7/z6U5uio98mL/gXPnx6dBpJ
pXNIVLtLAOA4DzdnnPmW3Dpv0yV1lGKRsw4ydNQUZirPbQT1AvjR4SusnbASiwdT
fuzJDwM5Ys9jMIzhgMt2kMPox6Gq8Zlexzi5JRJBW9mQW0MvtLwInNplTABLzlSw
FrvkYHlBF5VrIzBI0aQL4EYxQixN85xhSXlnFf8dAWda1BbQzNHUOTiB0Cf5VbDx
Bn5J1zyy2jYZcW8Sg/FZ
=WYtU
-----END PGP SIGNATURE-----
--=-=-=--