From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50490) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIFnW-0003tH-9r for qemu-devel@nongnu.org; Wed, 29 Jun 2016 09:45:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bIFnR-0007fR-Fv for qemu-devel@nongnu.org; Wed, 29 Jun 2016 09:44:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44209) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIFnR-0007f0-9y for qemu-devel@nongnu.org; Wed, 29 Jun 2016 09:44:53 -0400 From: Markus Armbruster References: <1466403224-16604-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1466403224-16604-14-git-send-email-caoj.fnst@cn.fujitsu.com> Date: Wed, 29 Jun 2016 15:44:50 +0200 In-Reply-To: <1466403224-16604-14-git-send-email-caoj.fnst@cn.fujitsu.com> (Cao jin's message of "Mon, 20 Jun 2016 14:13:44 +0800") Message-ID: <87mvm4w1m5.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v9 13/13] vmw_pvscsi: remove unnecessary internal msi state flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin Cc: qemu-devel@nongnu.org, Dmitry Fleytman , Paolo Bonzini , "Michael S. Tsirkin" , Marcel Apfelbaum Cao jin writes: > Internal flag msi_used is uncesessary, msi_uninit() could be called > directly, msi_enabled() is enough to check device msi state. > > But for migration compatibility, keep the field in structure. > > cc: Paolo Bonzini > cc: Dmitry Fleytman > cc: Markus Armbruster > cc: Marcel Apfelbaum > cc: Michael S. Tsirkin > > Signed-off-by: Cao jin Reviewed-by: Markus Armbruster