From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751976AbcFJIM2 (ORCPT ); Fri, 10 Jun 2016 04:12:28 -0400 Received: from mga01.intel.com ([192.55.52.88]:55598 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750900AbcFJIMZ (ORCPT ); Fri, 10 Jun 2016 04:12:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,449,1459839600"; d="asc'?scan'208";a="119462222" From: Felipe Balbi To: Roger Quadros , Grygorii Strashko Cc: tony@atomide.com, Joao.Pinto@synopsys.com, sergei.shtylyov@cogentembedded.com, peter.chen@freescale.com, jun.li@freescale.com, yoshihiro.shimoda.uh@renesas.com, nsekhar@ti.com, b-liu@ti.com, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 5/5] usb: dwc3: core: cleanup IRQ resources In-Reply-To: <575A7407.1090403@ti.com> References: <1462977406-22806-1-git-send-email-rogerq@ti.com> <1462977406-22806-6-git-send-email-rogerq@ti.com> <574E92E8.5080201@ti.com> <57501E0D.4010007@ti.com> <575A7407.1090403@ti.com> User-Agent: Notmuch/0.22+11~g124a67e (http://notmuchmail.org) Emacs/25.0.93.2 (x86_64-pc-linux-gnu) Date: Fri, 10 Jun 2016 11:11:27 +0300 Message-ID: <87mvmt79ao.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Roger Quadros writes: >> Is it expected to have more than one IRQ here? >>=20 >> if not - it will better to use platform_get_irq[_byname](). >>=20 > > The reason I used platform_get_resource variant is that i'm passing the > resource directly to the XHCI platform device below. >>=20 >>> + >>> + dwc->xhci_resources[1].start =3D res->start; >>> + dwc->xhci_resources[1].end =3D res->end; >>> + dwc->xhci_resources[1].flags =3D res->flags; >>> + dwc->xhci_resources[1].name =3D res->name; > > This could just change to > > dwc->xhci_resource[1] =3D *res; no, it cannot. Look at the definition of struct resource and how it's used, then you'll see we don't want to copy everything. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXWnYvAAoJEIaOsuA1yqRERYIP/3JdipsrGVqmJm0qMGYvbanl ZUWLtgVZgE8n43L4ZSoQR9pJvtoZ2vtQ8qViApmSux7l6+7gepGYaNRXt0VhdIvn fxaqsISxy58eOtAfRxFIN/vbSq9emWAG9mEyDLnyBlE4X1G0CQdQihi+FY331p4o C7/GbbGb+7PnPolYFzstPDO5RGr4gRPXyM2AhGMZiUaMGJBmEd8xfkJMsTTrT6mg CgnJ+H6CdSywOyHDGJjK2VhN+6wBNV4FAfVUcVBiSoFZvAQ0wgtmzUjvfaaS7f2G 6ALlEczdrEby3AIwlIHoCQeJ1cXFXh3j9r30pWqH5JZOgJaLXOggI6aBoF+izfno ESrYvTuzwFflhrdEg7wGX62X7Rv7TxCfhnnQhZFKRu+IVJQ9wnbPe8OWCYI5Qkbt OtLQkCmrqoj3k+fSkCJLCbSEE6gVsm6299eCLKTvDBCUqMkK7DhPj2N4ZHa2kIQU MG8mfuGxSWcIcmueFfq1+brF07s11+zK0T/kUgMWc1Mz7XKWuCmbcG+NdgVe8RKR HYhvS+9dCxTgoYQFXfH/LwJRoYLRsJirh8lHDT+reO9enZcrxchgLWFHj3P3FxSZ LMQxe9Htq89jg3RYAzvNkQgRa2vwz+jAtE5XD9BygpcoOI7DtRqy7BLCGF3wQOBH FiNd75oNccVZuEOybM5d =h/+M -----END PGP SIGNATURE----- --=-=-=--