From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apwoL-0000Sk-Dp for qemu-devel@nongnu.org; Tue, 12 Apr 2016 07:48:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1apwoH-0006T5-E6 for qemu-devel@nongnu.org; Tue, 12 Apr 2016 07:48:49 -0400 Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]:33876) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apwoH-0006Ss-7r for qemu-devel@nongnu.org; Tue, 12 Apr 2016 07:48:45 -0400 Received: by mail-wm0-x22e.google.com with SMTP id l6so184430053wml.1 for ; Tue, 12 Apr 2016 04:48:44 -0700 (PDT) References: <1459870344-16773-1-git-send-email-alex.bennee@linaro.org> <1459870344-16773-9-git-send-email-alex.bennee@linaro.org> <570C0E16.1030304@gmail.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <570C0E16.1030304@gmail.com> Date: Tue, 12 Apr 2016 12:48:47 +0100 Message-ID: <87mvozyrmo.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC v2 08/11] tcg: add options for enabling MTTCG List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Fedorov Cc: mttcg@listserver.greensocs.com, fred.konrad@greensocs.com, a.rigo@virtualopensystems.com, cota@braap.org, qemu-devel@nongnu.org, mark.burton@greensocs.com, pbonzini@redhat.com, jan.kiszka@siemens.com, rth@twiddle.net, peter.maydell@linaro.org, claudio.fontana@huawei.com, Peter Crosthwaite , Andreas =?utf-8?Q?F?= =?utf-8?Q?=C3=A4rber?= Peter Maydell Sergey Fedorov writes: > On 05/04/16 18:32, Alex Bennée wrote: >> diff --git a/qemu-options.hx b/qemu-options.hx >> index a770086..4eca704 100644 >> --- a/qemu-options.hx >> +++ b/qemu-options.hx >> @@ -3224,6 +3224,20 @@ Attach to existing xen domain. >> xend will use this when starting QEMU (XEN only). >> ETEXI >> >> +DEF("tcg", HAS_ARG, QEMU_OPTION_tcg, \ >> + "-tcg [mttcg=on|off] control TCG options\n", QEMU_ARCH_ALL) >> +STEXI >> +@item -tcg >> +@findex -tcg >> +@table @option >> +@item mttcg=[on|off] >> +Control multi-threaded TCG. By default QEMU will enable multi-threaded >> +emulation for front/back-end combinations that are known to work. The >> +user may enable it against the defaults however odd guest behaviour >> +may occur. >> +@end table >> +ETEXI > > Maybe we'd better use existing qemu accelerator framework and introduce > "-machine accel=mttcg" option? My worry would be breaking existing code which assumes kvm | tcg. We will want to enable mttcg by default for combos that work without having to tweak tooling that already uses the -machine options. -- Alex Bennée