From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35295)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XtE28-0007Og-Co
	for qemu-devel@nongnu.org; Tue, 25 Nov 2014 06:11:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XtE23-0003BD-PK
	for qemu-devel@nongnu.org; Tue, 25 Nov 2014 06:11:48 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <1416259239-13281-1-git-send-email-dslutz@verizon.com>
	<87k32r8jc8.fsf@blackfin.pond.sub.org>
	<546E339E.4030202@terremark.com>
	<87fvdd6j29.fsf@blackfin.pond.sub.org> <20141121104945.GH3165@work-vm>
	<5473D1CE.7040102@terremark.com> <20141125085915.GA2550@work-vm>
Date: Tue, 25 Nov 2014 12:11:36 +0100
In-Reply-To: <20141125085915.GA2550@work-vm> (David Alan Gilbert's message of
	"Tue, 25 Nov 2014 08:59:15 +0000")
Message-ID: <87mw7flel3.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 1/1] hw/ide/core.c: Prevent
	SIGSEGV during migration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, qemu-devel@nongnu.org, Don Slutz <dslutz@verizon.com>, qemu-stable@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

"Dr. David Alan Gilbert" <dgilbert@redhat.com> writes:

> * Don Slutz (dslutz@verizon.com) wrote:
>> On 11/21/14 05:49, Dr. David Alan Gilbert wrote:
>> >* Markus Armbruster (armbru@redhat.com) wrote:
[...]
>> >>Management tools should use -nodefaults.  But if it mixes default and
>> >>-nodefaults in migration, recreating the stuff it got by default but
>> >>doesn't get with -nodefaults is its own responsibility.
>> 
>> Yes. Since xen did not ask for a CD-ROM, it did not expect to need to create
>> it.   xen was "fixed" to use -nodefaults.
>> 
>> >Well, mostly - we wouldn't expect a migration to work if the source/dest
>> >didn't match exactly; but QEMU shouldn't seg.
>> 
>> Well, this change prevents a seg.  So you are in favor of having this
>> backported?
>
> Yes.

I gladly defer to Dave's judgement here.