From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCMlA-00031G-1z for qemu-devel@nongnu.org; Wed, 30 Jul 2014 01:49:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XCMl3-00071Z-TX for qemu-devel@nongnu.org; Wed, 30 Jul 2014 01:49:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5809) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCMl3-00071V-Lr for qemu-devel@nongnu.org; Wed, 30 Jul 2014 01:49:01 -0400 From: Markus Armbruster References: <1406302776-2306-1-git-send-email-sanidhya.iiith@gmail.com> <1406302776-2306-13-git-send-email-sanidhya.iiith@gmail.com> <53D7D14B.2020809@redhat.com> Date: Wed, 30 Jul 2014 07:48:57 +0200 In-Reply-To: <53D7D14B.2020809@redhat.com> (Eric Blake's message of "Tue, 29 Jul 2014 10:52:27 -0600") Message-ID: <87mwbrz99y.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH RFC v2 12/12] VMState test: hmp interface for cancel mechanism List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Juan Quintela , qemu list , "Dr. David Alan Gilbert" , Sanidhya Kashyap Eric Blake writes: > On 07/25/2014 09:39 AM, Sanidhya Kashyap wrote: >> Signed-off-by: Sanidhya Kashyap >> --- >> hmp-commands.hx | 14 ++++++++++++++ >> hmp.c | 6 ++++++ >> hmp.h | 1 + >> 3 files changed, 21 insertions(+) > > I don't mind if you squash the QMP and HMP counterpart commands into the > same patch as one another (throughout the series). Each pair of patches > are both small enough, and related to the same action, that doing it as > a combined patch may actually get a better review. It's okay to squash them when they're small and the interfaces they add are uncontroversial. Otherwise, I prefer them separate, so I can concentrate on the QMP interface first, without HMP distractions.